feat(i18n): translate system account & messaging surfaces (zh-CN/ja-JP/es-ES)#2906
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
documentation
Contributor
📓 Docs Drift CheckThis PR changes 4 package(s): 104 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
…P/es-ES)
- spec: allow _views.<view>.emptyState.{title,message} in object translation schema
- cli: extract emptyState keys in 'os i18n extract'
- platform-objects: fill missing zh-CN/ja-JP/es-ES for sys_user/sys_organization/sys_business_unit
- service-messaging: new ADR-0029 D8 MessagingTranslations bundle (7 sys_* objects), registered on kernel:ready
- sys-user.page.ts: tab/section/alert/add-button labels become inline
{ en, zh-CN, ja-JP, es-ES } objects; Security tab rebuilt on
record:quick_actions with actionNames so the change-password /
change-email / 2FA / delete-account buttons resolve object action
translations.
- sys-organization.page.ts / sys-position.page.ts: remaining hardcoded
tab titles and add labels get the same inline i18n objects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Localizes the
sys_user/sys_organization/sys_business_unit/sys_teamlist & detail pages, theaccount:profile_cardpage and thesys_inbox_messagemineview (user request). Framework side of a two-repo change — companion PR: objectui#2489.ObjectTranslationDataSchema/ObjectTranslationNodeSchemaaccept_views.<view>.emptyState.{title,message}so list-view empty states are translatable.os i18n extractemits_views.<view>.emptyStatekeys when a view declares an empty state.sys_user,sys_organization,sys_business_unit(fields, options, views, actions);sys_user/sys_organization/sys_positiondetail pages with inline{ en, 'zh-CN', 'ja-JP', 'es-ES' }i18n objects;record:quick_actions+actionNamesso change-password / change-email / 2FA / delete-account buttons resolve object action translations.MessagingTranslationsbundle covering the sevensys_*messaging objects, registered onkernel:ready; zh-CN fully translated, ja-JP/es-ES coversys_inbox_message(incl. themineview empty state).The inline i18n label objects only render localized once objectui#2489 lands — the console previously normalized the runtime locale to a bare base code (
zh) andpickLocalizedcouldn't upgrade back to thezh-CNmetadata keys. After that PR merges, runpnpm objectui:refreshhere to pull the fix into the vendored/_console.Tests
packages/platform-objects: 80/80 ✅ (pnpm -F @objectstack/platform-objects test)Live UI verification (real backend, Playwright, locales zh-CN / ja / es)
Backend from this branch's
platform-objectsdist on :18742, console dev server (with objectui#2489) on :5190. Full screenshot set: gist.Verified in all three locales:
mine:列头/空态/行内编辑(ja:「インライン編集」)Known remaining English (out of scope)
user(field data value, not a label).Created sys_team "…", server-generated).Changeset
.changeset/sys-tables-account-i18n.md— minor for@objectstack/spec/@objectstack/cli/@objectstack/service-messaging, patch for@objectstack/platform-objects.