Skip to content

Fix ENOTEMPTY error in build-schemas.ts during directory cleanup #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hotlong merged 2 commits into from
Feb 5, 2026
Merged

Fix ENOTEMPTY error in build-schemas.ts during directory cleanup #523

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9bc8810
Initial plan
Copilot Feb 5, 2026
7c81d37
fix: add retry logic to fs.rmSync to handle ENOTEMPTY errors
Copilot Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/spec/scripts/build-schemas.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const OUT_DIR = path.resolve(__dirname, '../json-schema');
// Clean output directory ensures no stale files remain
if (fs.existsSync(OUT_DIR)) {
console.log(`Cleaning output directory: ${OUT_DIR}`);
fs.rmSync(OUT_DIR, { recursive: true, force: true });
fs.rmSync(OUT_DIR, { recursive: true, force: true, maxRetries: 3, retryDelay: 100 });
Copy link

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same ENOTEMPTY error could occur in build-docs.ts which also uses recursive directory removal. Consider applying the same retry logic to the rmSync call on line 246 of build-docs.ts for consistency and to prevent similar CI failures.

Copilot uses AI. Check for mistakes.
}

// Ensure output directory exists
Expand Down
Loading