ci: add metadata test/lint gates (vitest + validate); fix broken lint step (#367)

CI called `pnpm run lint` but the repo had no `lint` script, so the
"Build and Test" workflow failed at the lint step on every commit
(pre-existing, also red on main). Aligns the scripts/CI with the
@objectstack metadata-app conventions (see framework examples).

package.json scripts:
- validate: `objectstack validate` — protocol/schema gate (blocking).
- lint:     `objectstack lint --skip-i18n` — metadata conventions (advisory).
- test:     `vitest run` — structural metadata smoke test (was the no-op
            `objectstack test`, which needs qa/*.test.json + a live server →
            kept as `test:qa`).
- verify:   validate && typecheck && build && test.

test/smoke.test.ts (vitest, no server — mirrors framework app-crm):
asserts manifest, core objects, all 16 flows incl. the 6 workflows[]-migrated
ones, and guards the 7.7 migration (no object `workflows[]`; every notify
`severity` ∈ info|warning|critical).

CI (ci.yml + code-quality.yml): blocking gates are now
validate + typecheck + build + test; `objectstack lint` runs advisory
(`continue-on-error`) because its `required/label` rule false-positives on
standard list-views (checks top-level `view.label`, but the view schema only
supports `list.label`) — filed upstream.

Co-authored-by: Jack Zhuang <277994282+os-zhuang@users.noreply.github.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

Author: 3 people

.github/workflows/ci.yml

@@ -34,15 +34,19 @@ jobs:
       - name: Install dependencies
         run: pnpm install --frozen-lockfile
 
-      - name: Run linter
+      - name: Validate metadata (protocol/schema)
+        run: pnpm run validate
+
+      - name: Lint metadata conventions (advisory)
         run: pnpm run lint
-      
+        continue-on-error: true
+
       - name: TypeScript type checking
         run: pnpm run typecheck
-      
+
       - name: Build project
         run: pnpm run build
-      
+
       - name: Run tests
         run: pnpm test
 

.github/workflows/code-quality.yml

@@ -51,10 +51,14 @@ jobs:
 
       - name: Check TypeScript compilation
         run: pnpm run typecheck
-      
-      - name: Run ESLint
+
+      - name: Validate metadata (protocol/schema)
+        run: pnpm run validate
+
+      - name: Lint metadata conventions (advisory)
         run: pnpm run lint
-      
+        continue-on-error: true
+
       - name: Check for TODO comments
         run: |
           echo "Checking for TODO/FIXME comments..."

package.json

@@ -14,8 +14,12 @@
     "start": "objectstack start -p 4001",
     "build": "objectstack build",
     "typecheck": "tsc --noEmit",
-    "test": "objectstack test",
+    "validate": "objectstack validate",
+    "lint": "objectstack lint --skip-i18n",
+    "test": "vitest run",
+    "test:qa": "objectstack test",
     "test:e2e": "playwright test",
+    "verify": "pnpm validate && pnpm typecheck && pnpm build && pnpm test",
     "demo:reset": "rm -rf .objectstack/data && pnpm build && echo '✅ DB reset — start the server with: pnpm dev (or pnpm start). Seed data loads on first boot.'"
   },
   "packageManager": "pnpm@10.33.0",
@@ -37,7 +41,8 @@
   },
   "devDependencies": {
     "@playwright/test": "^1.60.0",
-    "typescript": "^6.0.3"
+    "typescript": "^6.0.3",
+    "vitest": "^4.1.8"
   },
   "engines": {
     "node": ">=20",