Skip to content

Commit b033afc

Browse files
Copilothotlong
andcommitted
fix: add typecheck to CI, fix code-quality paths, align ESLint versions, document workspace exclusions
- CI workflow: add pnpm typecheck step - code-quality workflow: fix src/ → packages/ references, use typecheck instead of build - package.json: align @typescript-eslint/parser ^6.21.0 → ^7.18.0 with plugin - pnpm-workspace.yaml: add comment explaining core/server exclusion Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
1 parent cf45e51 commit b033afc

4 files changed

Lines changed: 11 additions & 5 deletions

File tree

.github/workflows/ci.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,9 @@ jobs:
3939
- name: Run linter
4040
run: pnpm run lint
4141

42+
- name: TypeScript type checking
43+
run: pnpm run typecheck
44+
4245
- name: Build project
4346
run: pnpm run build
4447

.github/workflows/code-quality.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ jobs:
4040

4141
- name: Check for console.log statements
4242
run: |
43-
if grep -r "console\.log" src/ --include="*.ts" --exclude-dir=node_modules; then
43+
if grep -r "console\.log" packages/ --include="*.ts" --exclude-dir=node_modules --exclude-dir=__tests__; then
4444
echo "Warning: console.log statements found in source code"
4545
echo "Please use proper logging instead"
4646
# This is just a warning, not failing the build
@@ -50,19 +50,19 @@ jobs:
5050
continue-on-error: true
5151

5252
- name: Check TypeScript compilation
53-
run: pnpm run build
53+
run: pnpm run typecheck
5454

5555
- name: Run ESLint
5656
run: pnpm run lint
5757

5858
- name: Check for TODO comments
5959
run: |
6060
echo "Checking for TODO/FIXME comments..."
61-
grep -r "TODO\|FIXME" src/ --include="*.ts" || echo "No TODO/FIXME found"
61+
grep -r "TODO\|FIXME" packages/ --include="*.ts" --exclude-dir=node_modules || echo "No TODO/FIXME found"
6262
continue-on-error: true
6363

6464
- name: Check file sizes
6565
run: |
6666
echo "Checking for large files..."
67-
find src/ -type f -size +100k -exec ls -lh {} \; || echo "No large files found"
67+
find packages/ -type f -size +100k -exec ls -lh {} \; || echo "No large files found"
6868
continue-on-error: true

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@
6767
"@objectstack/studio": "^3.0.8",
6868
"@types/node": "^25.2.3",
6969
"@typescript-eslint/eslint-plugin": "^7.18.0",
70-
"@typescript-eslint/parser": "^6.21.0",
70+
"@typescript-eslint/parser": "^7.18.0",
7171
"@vitest/coverage-v8": "^1.6.1",
7272
"@vitest/ui": "^1.6.1",
7373
"eslint": "^8.57.1",

pnpm-workspace.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
packages:
22
- 'apps/*'
33
- 'packages/*'
4+
# core and server are internal-only packages (private: true) excluded from
5+
# workspace linking to avoid circular dependency issues during builds.
6+
# They are consumed via tsconfig path aliases instead.
47
- '!packages/core'
58
- '!packages/server'

0 commit comments

Comments
 (0)