fix: drop removed ObjectSchema detail block (ADR-0085)#423
Merged
Conversation
framework ADR-0085 removed the per-surface `detail` UI-hints block from ObjectSchema — presentation intent now lives in cross-surface semantic roles (nameField / compactLayout→highlightFields / stageField / fieldGroups). `detail.hideReferenceRail` was a no-op here anyway: the Reference Rail is OFF by default and the only key that could enable it was never spec-typed, so these pages were already single-column without the flag. Removing the block changes no rendered behavior; it only restores typecheck against the new spec. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
framework ADR-0085 removed the per-surface
detailUI-hints block fromObjectSchema— presentation intent is now declared as cross-surface semantic roles (nameField/compactLayout→highlightFields/stageField/fieldGroups).This repo was the one downstream author of the block (caught by framework's Downstream backward-compat smoke — working exactly as designed 👏).
No behavior change:
detail.hideReferenceRailwas a proven no-op — the Reference Rail is OFF by default, and the only key that could turn it on (showReferenceRail) was never spec-typed, soproductandtaskdetail pages were already single-column without the flag. This PR only removes the dead keys so typecheck passes against the new spec.Unblocks the framework Release pipeline (currently red on this smoke).
🤖 Generated with Claude Code