refactor(agents): drop removed agent visibility field (spec 15 / ADR-0056 D8)#449
Merged
Conversation
…0056 D8) The upcoming @objectstack/spec release removes the unenforced agent `visibility` field (objectstack-ai/objectstack#3216). Omit it from the two copilot agents so hotcrm typechecks against both the current and the upcoming spec. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
xuyushun441-sys
pushed a commit
that referenced
this pull request
Jul 20, 2026
Bump all 11 @objectstack/* packages to 16.0.0-rc.1 (pinned exact for the RC), crossing the entire 15.x line. App → 2.2.0, manifest specVersion → ^16.0.0-rc.1. Breaking / behavioural changes migrated: - Drop `ai` from stack `requires`: ObjectStack 11.3.0 (ADR-0025 S2) removed @objectstack/service-ai from the open edition (AI runtime is cloud-only now), and under 16 `requires: ['ai']` is a fail-fast capability that hard-aborts boot when the package is absent. Agents/skills metadata still ship in the artifact; local open-edition boot omits the AI service. - The agent `visibility` removal (spec 15 / ADR-0056 D8) already landed on main via #449, so this branch (rebased onto it) is a no-op there. Dashboard fixes (found by rendering the app, not by `verify`): - dateRange picker now filters every widget query (ObjectStack 15, framework#2501); widgets on objects without the bound field (crm_account/contact/lead/product, no close_date) crashed with `no such column`. Opt them out via filterBindings: { dateRange: false }. - Remove non-functional dashboard header action buttons (Export PDF / Schedule Email / Customize / New-record / broken /reports links) from all 4 dashboards and the orphaned action-label translations from all 4 locale bundles. Toolchain: install under Node 22 (.nvmrc) — nanoid@6 engines + engine-strict reject the environment's odd-numbered Node 25. Verified: validate + typecheck + build + vitest (17/17) green; server boots (38 plugins); all 4 dashboards render with live seeded data and zero analytics/ console errors. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
os-zhuang
added a commit
that referenced
this pull request
Jul 20, 2026
Bump all 11 @objectstack/* packages to 16.0.0-rc.1 (pinned exact for the RC), crossing the entire 15.x line. App → 2.2.0, manifest specVersion → ^16.0.0-rc.1. Breaking / behavioural changes migrated: - Drop `ai` from stack `requires`: ObjectStack 11.3.0 (ADR-0025 S2) removed @objectstack/service-ai from the open edition (AI runtime is cloud-only now), and under 16 `requires: ['ai']` is a fail-fast capability that hard-aborts boot when the package is absent. Agents/skills metadata still ship in the artifact; local open-edition boot omits the AI service. - The agent `visibility` removal (spec 15 / ADR-0056 D8) already landed on main via #449, so this branch (rebased onto it) is a no-op there. Dashboard fixes (found by rendering the app, not by `verify`): - dateRange picker now filters every widget query (ObjectStack 15, framework#2501); widgets on objects without the bound field (crm_account/contact/lead/product, no close_date) crashed with `no such column`. Opt them out via filterBindings: { dateRange: false }. - Remove non-functional dashboard header action buttons (Export PDF / Schedule Email / Customize / New-record / broken /reports links) from all 4 dashboards and the orphaned action-label translations from all 4 locale bundles. Toolchain: install under Node 22 (.nvmrc) — nanoid@6 engines + engine-strict reject the environment's odd-numbered Node 25. Verified: validate + typecheck + build + vitest (17/17) green; server boots (38 plugins); all 4 dashboards render with live seeded data and zero analytics/ console errors. Co-authored-by: Jack Zhuang <277994282+os-zhuang@users.noreply.github.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upcoming
@objectstack/specrelease removes the unenforced agentvisibilityfield (objectstack-ai/objectstack#3216, ADR-0056 D8). hotcrm's two copilot agents still author it, which keeps framework's pre-publish downstream-compat smoke red and stalls the release train.This drops the two
visibility: 'organization'lines. Omitting the optional field typechecks against both the currently published spec (14.7) and the upcoming release.Verified locally by replicating framework's
downstream-smoke.sh: installed published deps, overlaid the freshly built unreleased spec dist, thenpnpm run typecheckandpnpm run validateboth pass (15 objects / 2 agents parse clean).After merge this ships as v2.1.0 (package.json is already 2.1.0), and framework bumps its smoke pin
HOTCRM_REFto v2.1.0.🤖 Generated with Claude Code