Address security concerns and improve test reliability

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>

Author: Copilot

.github/workflows/test-lifecycle.yml

@@ -24,7 +24,7 @@ jobs:
       - name: Setup pnpm
         uses: pnpm/action-setup@v4
         with:
-          version: 10
+          version: '10.x'
 
       - name: Install dependencies
         run: pnpm install
@@ -37,7 +37,7 @@ jobs:
         uses: actions/upload-artifact@v4
         with:
           name: quick-test-results
-          path: /tmp/test-*.log
+          path: /tmp/objectdocs-*.log
           retention-days: 7
           if-no-files-found: ignore
 
@@ -57,7 +57,7 @@ jobs:
       - name: Setup pnpm
         uses: pnpm/action-setup@v4
         with:
-          version: 10
+          version: '10.x'
 
       - name: Install dependencies
         run: pnpm install
@@ -70,8 +70,6 @@ jobs:
         uses: actions/upload-artifact@v4
         with:
           name: full-test-results
-          path: |
-            /tmp/dev-server.log
-            /tmp/start-server.log
+          path: /tmp/objectdocs-*.log
           retention-days: 7
           if-no-files-found: ignore

test-quick.sh

@@ -25,7 +25,7 @@ print_error() {
     echo -e "${RED}✗${NC} $1"
 }
 
-TEST_DIR="/tmp/objectdocs-quick-test-$(date +%s)"
+TEST_DIR=$(mktemp -d -t objectdocs-quick-test.XXXXXXXXXX)
 
 # Cleanup on exit
 cleanup() {

test-site.sh

@@ -13,11 +13,11 @@ BLUE='\033[0;34m'
 NC='\033[0m' # No Color
 
 # Configuration
-TEST_DIR="/tmp/objectdocs-test-$(date +%s)"
-LOG_DIR="/tmp/objectdocs-logs-$(date +%s)"
-PORT=7777
-BUILD_TIMEOUT=300  # 5 minutes for build
-DEV_TIMEOUT=30     # 30 seconds for dev server to start
+TEST_DIR=$(mktemp -d -t objectdocs-test.XXXXXXXXXX)
+LOG_DIR=$(mktemp -d -t objectdocs-logs.XXXXXXXXXX)
+PORT="${PORT:-7777}"  # Allow override via environment variable
+BUILD_TIMEOUT="${BUILD_TIMEOUT:-300}"  # 5 minutes for build
+DEV_TIMEOUT="${DEV_TIMEOUT:-30}"       # 30 seconds for dev server to start
 
 # Cleanup function
 cleanup() {
@@ -37,9 +37,13 @@ cleanup() {
     fi
 
     # Kill any process using the test port (gracefully)
-    lsof -ti:$PORT | xargs kill 2>/dev/null || true
-    sleep 1
-    lsof -ti:$PORT | xargs kill -9 2>/dev/null || true
+    if lsof -ti:$PORT >/dev/null 2>&1; then
+        lsof -ti:$PORT | xargs kill 2>/dev/null || true
+        sleep 1
+        if lsof -ti:$PORT >/dev/null 2>&1; then
+            lsof -ti:$PORT | xargs kill -9 2>/dev/null || true
+        fi
+    fi
 
     # Remove test directory (force recursive delete)
     if [ -d "$TEST_DIR" ]; then