fix(web): add resolveFields helper to eliminate non-null assertions on field names

Address code review feedback:
- Add ResolvedField type with guaranteed name and label
- Add resolveFields() helper to safely resolve field entries
- Use resolveFields() in RecordTable and ObjectRecordPage
- Eliminate all field.name! non-null assertions

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>

Author: Copilot

apps/web/src/components/records/RecordTable.tsx

@@ -15,7 +15,8 @@ import {
   TableRow,
 } from '@/components/ui/table';
 import { FieldRenderer } from './FieldRenderer';
-import type { ObjectDefinition, RecordData } from '@/types/metadata';
+import type { ObjectDefinition, RecordData, ResolvedField } from '@/types/metadata';
+import { resolveFields } from '@/types/metadata';
 
 interface RecordTableProps {
   objectDef: ObjectDefinition;
@@ -24,13 +25,19 @@ interface RecordTableProps {
 }
 
 export function RecordTable({ objectDef, records, basePath }: RecordTableProps) {
-  const columnNames =
-    objectDef.listFields ??
-    Object.keys(objectDef.fields).filter((k) => k !== 'id' && !objectDef.fields[k].readonly);
+  const allResolved = resolveFields(objectDef.fields, ['id']);
 
-  const columns = columnNames
-    .map((name) => ({ ...objectDef.fields[name], name }))
-    .filter((f) => f.type);
+  let columns: ResolvedField[];
+  if (objectDef.listFields) {
+    // Use specified list fields in order
+    const fieldMap = new Map(allResolved.map((f) => [f.name, f]));
+    columns = objectDef.listFields
+      .map((name) => fieldMap.get(name))
+      .filter((f): f is ResolvedField => !!f);
+  } else {
+    // Fallback: all non-readonly fields
+    columns = allResolved.filter((f) => !f.readonly);
+  }
 
   if (records.length === 0) {
     return (
@@ -49,7 +56,7 @@ export function RecordTable({ objectDef, records, basePath }: RecordTableProps)
         <TableHeader>
           <TableRow>
             {columns.map((col) => (
-              <TableHead key={col.name}>{col.label ?? col.name}</TableHead>
+              <TableHead key={col.name}>{col.label}</TableHead>
             ))}
           </TableRow>
         </TableHeader>

apps/web/src/pages/apps/object-record.tsx

@@ -12,6 +12,7 @@ import { FieldRenderer } from '@/components/records/FieldRenderer';
 import { Card, CardContent, CardHeader, CardTitle } from '@/components/ui/card';
 import { Button } from '@/components/ui/button';
 import { Separator } from '@/components/ui/separator';
+import { resolveFields } from '@/types/metadata';
 
 export default function ObjectRecordPage() {
   const { appId, objectName, recordId } = useParams();
@@ -51,9 +52,7 @@ export default function ObjectRecordPage() {
   const recordTitle = String(record[primaryField] ?? record.id ?? 'Untitled');
 
   // Group fields: primary info fields vs metadata/readonly fields
-  const allFields = Object.entries(objectDef.fields)
-    .filter(([key]) => key !== 'id')
-    .map(([key, f]) => ({ ...f, name: f.name ?? key }));
+  const allFields = resolveFields(objectDef.fields, ['id']);
   const editableFields = allFields.filter((f) => !f.readonly);
   const readonlyFields = allFields.filter((f) => f.readonly);
 
@@ -81,10 +80,10 @@ export default function ObjectRecordPage() {
             {editableFields.map((field) => (
               <div key={field.name}>
                 <dt className="text-sm font-medium text-muted-foreground">
-                  {field.label ?? field.name}
+                  {field.label}
                 </dt>
                 <dd className="mt-1 text-sm">
-                  <FieldRenderer field={field} value={record[field.name!]} />
+                  <FieldRenderer field={field} value={record[field.name]} />
                 </dd>
               </div>
             ))}
@@ -97,10 +96,10 @@ export default function ObjectRecordPage() {
                 {readonlyFields.map((field) => (
                   <div key={field.name}>
                     <dt className="text-sm font-medium text-muted-foreground">
-                      {field.label ?? field.name}
+                      {field.label}
                     </dt>
                     <dd className="mt-1 text-sm">
-                      <FieldRenderer field={field} value={record[field.name!]} />
+                      <FieldRenderer field={field} value={record[field.name]} />
                     </dd>
                   </div>
                 ))}

apps/web/src/types/metadata.ts

@@ -83,6 +83,32 @@ export interface FieldDefinition {
   formula?: string;
 }
 
+/**
+ * A FieldDefinition with its `name` guaranteed to be present.
+ * Use `resolveFields()` to convert raw object field entries.
+ */
+export interface ResolvedField extends FieldDefinition {
+  name: string;
+  label: string;
+}
+
+/**
+ * Resolve raw field entries from an ObjectDefinition, ensuring every
+ * field has a `name` (from the record key) and a `label` (fallback to name).
+ */
+export function resolveFields(
+  fields: Record<string, FieldDefinition>,
+  exclude?: string[],
+): ResolvedField[] {
+  return Object.entries(fields)
+    .filter(([key]) => !exclude?.includes(key))
+    .map(([key, f]) => ({
+      ...f,
+      name: f.name ?? key,
+      label: f.label ?? f.name ?? key,
+    }));
+}
+
 // ── Object Definition ───────────────────────────────────────────
 
 export interface ObjectDefinition {