fix: address code review feedback - UUID, delete total check, a11y labels, key matching

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>

Author: Copilot

apps/web/src/components/sync/ConflictResolutionDialog.tsx

@@ -54,8 +54,12 @@ export function ConflictResolutionDialog({
             <thead>
               <tr className="border-b bg-muted/50">
                 <th className="px-3 py-2 text-left font-medium" scope="col">Field</th>
-                <th className="px-3 py-2 text-left font-medium" scope="col">Local</th>
-                <th className="px-3 py-2 text-left font-medium" scope="col">Server</th>
+                <th className="px-3 py-2 text-left font-medium" scope="col">
+                  <span className="mr-1">◀</span> Local
+                </th>
+                <th className="px-3 py-2 text-left font-medium" scope="col">
+                  Server <span className="ml-1">▶</span>
+                </th>
               </tr>
             </thead>
             <tbody>

apps/web/src/hooks/use-keyboard-shortcuts.ts

@@ -47,12 +47,15 @@ export function useKeyboardShortcuts(shortcuts: KeyboardShortcut[]) {
       const shiftMatch = shortcut.shift ? event.shiftKey : !event.shiftKey;
       const altMatch = shortcut.alt ? event.altKey : !event.altKey;
 
-      if (
-        event.key.toLowerCase() === shortcut.key.toLowerCase() &&
-        ctrlMatch &&
-        shiftMatch &&
-        altMatch
-      ) {
+      // Compare key with case sensitivity: use event.key directly for
+      // special keys (length > 1) or shifted characters (e.g. '?').
+      // For single alpha characters, compare case-insensitively.
+      const keyMatches =
+        shortcut.key.length === 1 && /[a-zA-Z]/.test(shortcut.key)
+          ? event.key.toLowerCase() === shortcut.key.toLowerCase()
+          : event.key === shortcut.key;
+
+      if (keyMatches && ctrlMatch && shiftMatch && altMatch) {
         if (!shortcut.allowInInput && isInputFocused()) continue;
 
         event.preventDefault();

apps/web/src/hooks/use-records.ts

@@ -107,7 +107,7 @@ export function useCreateRecord({ objectName }: UseCreateRecordOptions) {
       const previous = queryClient.getQueriesData<RecordListResponse>({ queryKey: ['records', objectName] });
       queryClient.setQueriesData<RecordListResponse>(
         { queryKey: ['records', objectName] },
-        (old) => old ? { ...old, records: [...old.records, { id: `optimistic-${Date.now()}`, ...newData } as RecordData], total: old.total + 1 } : old,
+        (old) => old ? { ...old, records: [...old.records, { id: crypto.randomUUID(), ...newData } as RecordData], total: old.total + 1 } : old,
       );
       return { previous };
     },
@@ -181,7 +181,12 @@ export function useDeleteRecord({ objectName }: UseDeleteRecordOptions) {
       const previous = queryClient.getQueriesData<RecordListResponse>({ queryKey: ['records', objectName] });
       queryClient.setQueriesData<RecordListResponse>(
         { queryKey: ['records', objectName] },
-        (old) => old ? { ...old, records: old.records.filter((r) => String(r.id) !== recordId), total: Math.max(0, old.total - 1) } : old,
+        (old) => {
+          if (!old) return old;
+          const filtered = old.records.filter((r) => String(r.id) !== recordId);
+          const removed = filtered.length < old.records.length;
+          return { ...old, records: filtered, total: removed ? Math.max(0, old.total - 1) : old.total };
+        },
       );
       return { previous };
     },