fix: address code review feedback — remove duplicate forms, sanitize filters, fix icon and toolbar count

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>

Author: Copilot

apps/web/src/components/layouts/AppLayout.tsx

@@ -1,5 +1,5 @@
 import { Link, useLocation, useParams, Outlet } from 'react-router-dom';
-import { Database, LayoutDashboard, ChevronRight, Star } from 'lucide-react';
+import { Database, LayoutDashboard, ChevronRight, Clock } from 'lucide-react';
 import {
   Sidebar,
   SidebarContent,
@@ -143,7 +143,7 @@ export function AppLayout() {
                     <SidebarMenuItem key={item.id}>
                       <SidebarMenuButton asChild isActive={pathname === item.href} tooltip={item.title}>
                         <Link to={item.href}>
-                          <Star className="size-3.5" />
+                          <Clock className="size-3.5" />
                           <span className="truncate">{item.title}</span>
                         </Link>
                       </SidebarMenuButton>

apps/web/src/hooks/use-records.ts

@@ -53,7 +53,11 @@ export function useRecords({
         }
         if (filters?.length) {
           params.filter = filters.map(
-            (f) => `${f.field} ${f.operator} '${f.value}'`,
+            (f) => {
+              // Sanitize: escape single quotes in values to prevent filter injection
+              const safeValue = f.value.replace(/'/g, "''");
+              return `${f.field} ${f.operator} '${safeValue}'`;
+            },
           ).join(' and ');
         }
         const result = await objectStackClient.data.find(objectName, params);

apps/web/src/pages/apps/object-list.tsx

@@ -8,7 +8,7 @@
  * Route: /apps/:appId/:objectName
  */
 
-import { useState, useMemo, useCallback } from 'react';
+import { useState, useCallback } from 'react';
 import { useParams, Link, useSearchParams } from 'react-router-dom';
 import { ArrowLeft } from 'lucide-react';
 import { SchemaRenderer } from '@object-ui/react';
@@ -41,42 +41,6 @@ export default function ObjectListPage() {
 
   const isLoading = metaLoading || dataLoading;
 
-  // Client-side filtering for search and filters (H.3.3)
-  const filteredRecords = useMemo(() => {
-    let records = result?.records ?? [];
-
-    // Apply text search
-    if (searchTerm) {
-      const term = searchTerm.toLowerCase();
-      records = records.filter((r) =>
-        Object.values(r).some((v) =>
-          v != null && String(v).toLowerCase().includes(term),
-        ),
-      );
-    }
-
-    // Apply field filters
-    for (const filter of filters) {
-      records = records.filter((r) => {
-        const val = String(r[filter.field] ?? '').toLowerCase();
-        switch (filter.operator) {
-          case 'equals':
-            return val === filter.value.toLowerCase();
-          case 'contains':
-            return val.includes(filter.value.toLowerCase());
-          case 'gt':
-            return Number(r[filter.field]) > Number(filter.value);
-          case 'lt':
-            return Number(r[filter.field]) < Number(filter.value);
-          default:
-            return true;
-        }
-      });
-    }
-
-    return records;
-  }, [result?.records, searchTerm, filters]);
-
   const handlePageChange = useCallback(
     (page: number) => {
       setSearchParams({ page: String(page) });
@@ -132,7 +96,7 @@ export default function ObjectListPage() {
       {/* Toolbar — H.4.2 */}
       <ObjectToolbar
         objectDef={objectDef}
-        total={filteredRecords.length}
+        total={total}
         viewMode={viewMode}
         onViewChange={setViewMode}
         createPath={createPath}

apps/web/src/pages/apps/record-create.tsx

@@ -14,7 +14,6 @@ import { SchemaRenderer } from '@object-ui/react';
 import { objectUIAdapter } from '@/lib/object-ui-adapter';
 import { useObjectDefinition } from '@/hooks/use-metadata';
 import { useCreateRecord } from '@/hooks/use-records';
-import { MetadataForm } from '@/components/objectui/MetadataForm';
 import { Button } from '@/components/ui/button';
 import type { RecordData } from '@/types/metadata';
 
@@ -95,14 +94,6 @@ export default function RecordCreatePage() {
           onCancel={handleCancel}
         />
       </div>
-
-      {/* Fallback form using local MetadataForm */}
-      <MetadataForm
-        objectDef={objectDef}
-        onSubmit={handleSubmit}
-        onCancel={handleCancel}
-        isSubmitting={createMutation.isPending}
-      />
     </div>
   );
 }

apps/web/src/pages/apps/record-edit.tsx

@@ -15,7 +15,6 @@ import { SchemaRenderer } from '@object-ui/react';
 import { objectUIAdapter } from '@/lib/object-ui-adapter';
 import { useObjectDefinition } from '@/hooks/use-metadata';
 import { useRecord, useUpdateRecord } from '@/hooks/use-records';
-import { MetadataForm } from '@/components/objectui/MetadataForm';
 import { Button } from '@/components/ui/button';
 import type { RecordData } from '@/types/metadata';
 
@@ -101,15 +100,6 @@ export default function RecordEditPage() {
           onCancel={handleCancel}
         />
       </div>
-
-      {/* Fallback form using local MetadataForm */}
-      <MetadataForm
-        objectDef={objectDef}
-        record={record}
-        onSubmit={handleSubmit}
-        onCancel={handleCancel}
-        isSubmitting={updateMutation.isPending}
-      />
     </div>
   );
 }