Commit ce8d6b1
fix(one): sign bundled Node with JIT entitlements to stop macOS crash-loop
The macOS app crash-loops on launch ("sidecar exited; restarting") because
the bundled Node runtime is killed the instant V8 initializes. CI signs the
Node binary with hardened runtime (--options runtime, required for
notarization) but passed no entitlements, so macOS blocks V8's JIT executable
memory and kills node with SIGTRAP (exit 133) before it prints anything.
Add runtime-entitlements.plist (com.apple.security.cs.allow-jit +
allow-unsigned-executable-memory + disable-library-validation) and pass it via
--entitlements in the pre-sign step. Verified on the shipped 7.6.0 binary:
as-signed → exit 133; re-signed with these entitlements → runs (node v22).
Also fail the build if allow-jit is ever missing from the node binary, so this
brick can't ship again. Affected 7.2.x–7.6.0 identically; ship as 7.6.1.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>1 parent 32894a5 commit ce8d6b1
2 files changed
Lines changed: 42 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
179 | 179 | | |
180 | 180 | | |
181 | 181 | | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
182 | 190 | | |
183 | 191 | | |
184 | 192 | | |
| |||
188 | 196 | | |
189 | 197 | | |
190 | 198 | | |
191 | | - | |
| 199 | + | |
| 200 | + | |
192 | 201 | | |
193 | 202 | | |
194 | 203 | | |
| |||
197 | 206 | | |
198 | 207 | | |
199 | 208 | | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
200 | 224 | | |
201 | 225 | | |
202 | 226 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
0 commit comments