Address code review: improve type safety and error handling

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>

Author: Copilot

examples/showcase/enterprise-erp/tsconfig.json

@@ -6,5 +6,8 @@
     "resolveJsonModule": true
   },
   "include": ["src/**/*"],
-  "exclude": ["node_modules", "dist"]
+  "exclude": ["node_modules", "dist"],
+  "references": [
+    { "path": "../../../packages/foundation/types" }
+  ]
 }

packages/foundation/core/src/app.ts

@@ -77,10 +77,16 @@ export class ObjectQL implements IObjectQL {
         if (config.registry) {
             // Copy metadata from provided registry to kernel's registry
             for (const type of config.registry.getTypes()) {
-                for (const item of config.registry.list(type)) {
+                const items = config.registry.list(type);
+                for (const item of items) {
+                    // Safely extract the item's id/name
+                    const itemId = typeof item === 'object' && item !== null 
+                        ? (item as { name?: string; id?: string }).name || (item as { name?: string; id?: string }).id || 'unknown'
+                        : 'unknown';
+                    
                     this.kernel.metadata.register(type, {
                         type,
-                        id: (item as any).name || (item as any).id,
+                        id: itemId,
                         content: item
                     });
                 }

packages/foundation/core/src/query/filter-translator.ts

@@ -8,6 +8,7 @@
 
 import type { Filter } from '@objectql/types';
 import type { FilterNode } from '@objectstack/spec';
+import { ObjectQLError } from '@objectql/types';
 
 /**
  * Filter Translator
@@ -63,7 +64,10 @@ export class FilterTranslator {
 
         // Note: $not operator is not currently supported in the legacy FilterNode format
         if (filter.$not) {
-            throw new Error('$not operator is not supported. Use $ne for field negation instead.');
+            throw new ObjectQLError({
+                code: 'UNSUPPORTED_OPERATOR',
+                message: '$not operator is not supported. Use $ne for field negation instead.'
+            });
         }
 
         // Process field conditions

packages/foundation/core/src/repository.ts

@@ -38,7 +38,7 @@ export class ObjectRepository {
         return this.app.getKernel();
     }
 
-    private getOptions(extra: any = {}) {
+    private getOptions(extra: Record<string, unknown> = {}) {
         return {
             transaction: this.context.transactionHandle,
             ...extra

packages/foundation/platform-node/src/loader.ts

@@ -298,7 +298,7 @@ function registerObject(registry: MetadataRegistry, obj: any, file: string, pack
     // Check for existing object to Merge
     const existing = registry.getEntry('object', obj.name);
     if (existing) {
-        const base = existing.content;
+        const base = existing.content as ObjectConfig;
 
         // Merge Fields: New fields overwrite old ones
         if (obj.fields) {

packages/foundation/types/src/registry.ts

@@ -23,5 +23,5 @@ export interface Metadata {
     id: string;
     path?: string;
     package?: string;
-    content: any;
+    content: unknown;
 }

packages/objectstack/runtime/src/actions.ts

@@ -5,6 +5,17 @@
  * Provides a system for registering and executing custom actions on objects
  */
 
+/**
+ * Runtime Error
+ * Simple error class for runtime package
+ */
+export class RuntimeError extends Error {
+    constructor(public code: string, message: string) {
+        super(message);
+        this.name = 'RuntimeError';
+    }
+}
+
 /**
  * Action Context
  * Context passed to action handlers
@@ -80,7 +91,10 @@ export class ActionManager {
         const entry = this.actions.get(key);
 
         if (!entry) {
-            throw new Error(`Action '${actionName}' not found for object '${objectName}'`);
+            throw new RuntimeError(
+                'ACTION_NOT_FOUND',
+                `Action '${actionName}' not found for object '${objectName}'`
+            );
         }
 
         return await entry.handler(ctx);

packages/objectstack/runtime/src/metadata.ts

@@ -16,7 +16,7 @@ export interface MetadataItem {
     /** Unique identifier */
     id: string;
     /** The actual metadata content */
-    content: any;
+    content: unknown;
     /** Package name this metadata belongs to */
     packageName?: string;
     /** Optional path to the metadata source file */
@@ -113,7 +113,7 @@ export class MetadataRegistry {
         const items = this.packages.get(packageName);
         if (!items) {
             // Also try to find by scanning all entries (for compatibility)
-            for (const [type, typeMap] of this.store.entries()) {
+            for (const [, typeMap] of this.store.entries()) {
                 const entriesToDelete: string[] = [];
                 for (const [id, item] of typeMap.entries()) {
                     if (item.package === packageName || item.packageName === packageName) {