Fix OData query parameter parsing - decode parameter names

Fixed URL query parameter parsing by decoding both keys and values. Previously only values were decoded, causing %24filter (URL-encoded $filter) to not match the expected $filter parameter name.

Also fixed path parsing to strip query string before extracting entity set name.

Progress: 122/126 tests passing (96.8% pass rate), down to 4 failures from original 12.

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>

Author: Copilot

packages/protocols/odata-v4/src/index.ts

@@ -373,7 +373,9 @@ export class ODataV4Plugin implements RuntimePlugin {
         }
 
         try {
-            const path = url.substring(basePath.length) || '/';
+            // Extract path without query string
+            const urlWithoutQuery = url.split('?')[0];
+            const path = urlWithoutQuery.substring(basePath.length) || '/';
 
             // Route to appropriate handler
             if (path === '/' || path === '') {
@@ -724,7 +726,8 @@ export class ODataV4Plugin implements RuntimePlugin {
         for (const pair of pairs) {
             const [key, value] = pair.split('=');
             if (key) {
-                params[key as keyof ODataQueryParams] = decodeURIComponent(value || '');
+                const decodedKey = decodeURIComponent(key);
+                params[decodedKey as keyof ODataQueryParams] = decodeURIComponent(value || '');
             }
         }
 

packages/protocols/odata-v4/src/tck.test.ts

@@ -228,12 +228,20 @@ class ODataEndpoint implements ProtocolEndpoint {
     });
 
     if (!response.ok) {
-      const error = await response.json();
+      let errorMessage = 'Query failed';
+      let errorCode = 'QUERY_ERROR';
+      try {
+        const error = await response.json();
+        errorCode = error.error?.code || 'QUERY_ERROR';
+        errorMessage = error.error?.message || 'Query failed';
+      } catch (e) {
+        errorMessage = `HTTP ${response.status}: ${await response.text().catch(() => 'No error message')}`;
+      }
       return {
         success: false,
         error: {
-          code: error.error?.code || 'QUERY_ERROR',
-          message: error.error?.message || 'Query failed'
+          code: errorCode,
+          message: errorMessage
         }
       };
     }