Merge pull request #135 from objectstack-ai/copilot/refactor-objectql-adherence

Author: huangyiirene

packages/foundation/core/src/util.ts

@@ -110,7 +110,10 @@ export function convertIntrospectedSchemaToObjects(
 
             if (foreignKey) {
                 // This is a lookup field
+                // Note: name must be set explicitly here since we're creating the config programmatically.
+                // When defined in YAML (ObjectConfig.fields Record), the name is auto-populated from the key.
                 fieldConfig = {
+                    name: column.name,
                     type: 'lookup',
                     reference_to: foreignKey.referencedTable,
                     label: toTitleCase(column.name),
@@ -120,7 +123,10 @@ export function convertIntrospectedSchemaToObjects(
                 // Regular field
                 const fieldType = mapDatabaseTypeToFieldType(column.type);
 
+                // Note: name must be set explicitly here since we're creating the config programmatically.
+                // When defined in YAML (ObjectConfig.fields Record), the name is auto-populated from the key.
                 fieldConfig = {
+                    name: column.name,
                     type: fieldType,
                     label: toTitleCase(column.name),
                     required: !column.nullable
@@ -133,7 +139,7 @@ export function convertIntrospectedSchemaToObjects(
 
                 // Add max length for text fields
                 if (column.maxLength && (fieldType === 'text' || fieldType === 'textarea')) {
-                    fieldConfig.max_length = column.maxLength;
+                    fieldConfig.maxLength = column.maxLength;
                 }
 
                 // Add default value

packages/foundation/core/src/validator.ts

@@ -190,11 +190,10 @@ export class Validator {
                 }
             }
 
-            // Pattern validation (supports both pattern and deprecated regex)
-            const patternValue = validation.pattern ?? validation.regex;
-            if (patternValue) {
+            // Pattern validation
+            if (validation.pattern) {
                 try {
-                    const pattern = new RegExp(patternValue);
+                    const pattern = new RegExp(validation.pattern);
                     if (!pattern.test(String(value))) {
                         results.push({
                             rule: `${fieldName}_pattern`,
@@ -208,7 +207,7 @@ export class Validator {
                     results.push({
                         rule: `${fieldName}_pattern`,
                         valid: false,
-                        message: `Invalid regex pattern: ${patternValue}`,
+                        message: `Invalid regex pattern: ${validation.pattern}`,
                         severity: 'error',
                         fields: [fieldName],
                     });

packages/foundation/core/test/util.test.ts

@@ -327,7 +327,7 @@ describe('Utility Functions', () => {
             const objects = convertIntrospectedSchemaToObjects(schema);
             const fields = objects[0].fields!;
 
-            expect(fields.short_text.max_length).toBe(100);
+            expect(fields.short_text.maxLength).toBe(100);
         });
 
         it('should add default value when present', () => {

packages/foundation/types/package.json

@@ -22,10 +22,13 @@
     "schemas"
   ],
   "scripts": {
-    "build": "tsc && npm run generate:schemas",
+    "build": "tsc",
     "generate:schemas": "node scripts/generate-schemas.js",
     "test": "jest --passWithNoTests"
   },
+  "dependencies": {
+    "@objectstack/spec": "^0.1.1"
+  },
   "devDependencies": {
     "ts-json-schema-generator": "^2.4.0"
   }

packages/foundation/types/src/action.ts

@@ -6,9 +6,21 @@
  * LICENSE file in the root directory of this source tree.
  */
 
+// Import and re-export types from the Protocol Constitution (@objectstack/spec)
+import type { Action } from '@objectstack/spec';
 import { FieldConfig } from "./field";
 import { HookAPI } from "./hook"; // Reuse the restricted API interface
 
+/**
+ * Re-export Protocol Types from the Constitution
+ */
+export type { Action as SpecAction };
+
+/**
+ * RUNTIME-SPECIFIC TYPES
+ * The following types extend the Protocol Action definition with runtime execution capabilities
+ */
+
 /**
  * Defines the scope of the action.
  * - `record`: Acts on a specific record instance (e.g. "Approve Order").
@@ -24,6 +36,8 @@ export type ActionInputDefinition = Record<string, FieldConfig>;
 
 /**
  * Context passed to the action handler execution.
+ * 
+ * RUNTIME TYPE: Used during action execution.
  */
 export interface ActionContext<BaseT = any, InputT = any> {
     /** The object this action belongs to. */
@@ -58,11 +72,19 @@ export interface ActionContext<BaseT = any, InputT = any> {
 }
 
 /**
+ * Runtime Action Configuration
+ * 
  * The configuration of an Action visible to the Metadata engine (YAML/JSON side).
+ * Compatible with Protocol Action but adds runtime-specific options.
  */
 export interface ActionConfig {
+    /** Display label */
     label?: string;
+    
+    /** Description */
     description?: string;
+    
+    /** Icon name */
     icon?: string;
 
     /**
@@ -93,6 +115,8 @@ export interface ActionConfig {
 
 /**
  * The full implementation definition (Code side).
+ * 
+ * RUNTIME TYPE: Includes the handler function for execution.
  */
 export interface ActionDefinition<BaseT = any, InputT = any, ReturnT = any> extends ActionConfig {
     /**