Skip to content

Commit 86cef4e

Browse files
Copilothotlong
andcommitted
Fix CI typecheck errors - update driver supports and remove DriverInterface conflict
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
1 parent 0d03737 commit 86cef4e

File tree

5 files changed

+36
-6
lines changed

5 files changed

+36
-6
lines changed

packages/drivers/mongo/src/index.ts

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ export interface CommandResult {
4343
*
4444
* The driver internally converts QueryAST format to MongoDB query format.
4545
*/
46-
export class MongoDriver implements Driver, DriverInterface {
46+
export class MongoDriver implements Driver {
4747
// Driver metadata (ObjectStack-compatible)
4848
public readonly name = 'MongoDriver';
4949
public readonly version = '3.0.1';
@@ -52,7 +52,13 @@ export class MongoDriver implements Driver, DriverInterface {
5252
joins: false,
5353
fullTextSearch: true,
5454
jsonFields: true,
55-
arrayFields: true
55+
arrayFields: true,
56+
queryFilters: true,
57+
queryAggregations: true,
58+
querySorting: true,
59+
queryPagination: true,
60+
queryWindowFunctions: false,
61+
querySubqueries: false
5662
};
5763

5864
private client: MongoClient;

packages/drivers/sdk/src/index.ts

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ function createTimeoutSignal(ms: number): AbortSignal {
142142
*
143143
* @version 4.0.0 - DriverInterface compliant
144144
*/
145-
export class RemoteDriver implements Driver, DriverInterface {
145+
export class RemoteDriver implements Driver {
146146
// Driver metadata (ObjectStack-compatible)
147147
public readonly name = 'RemoteDriver';
148148
public readonly version = '4.0.0';
@@ -151,7 +151,13 @@ export class RemoteDriver implements Driver, DriverInterface {
151151
joins: false,
152152
fullTextSearch: false,
153153
jsonFields: true,
154-
arrayFields: true
154+
arrayFields: true,
155+
queryFilters: true,
156+
queryAggregations: true,
157+
querySorting: true,
158+
queryPagination: true,
159+
queryWindowFunctions: false,
160+
querySubqueries: false
155161
};
156162

157163
private rpcPath: string;

packages/drivers/sql/src/index.ts

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ export interface CommandResult {
4646
*
4747
* @version 4.0.0 - DriverInterface compliant
4848
*/
49-
export class SqlDriver implements Driver, DriverInterface {
49+
export class SqlDriver implements Driver {
5050
// Driver metadata (ObjectStack-compatible)
5151
public readonly name = 'SqlDriver';
5252
public readonly version = '4.0.0';
@@ -55,7 +55,13 @@ export class SqlDriver implements Driver, DriverInterface {
5555
joins: true,
5656
fullTextSearch: false,
5757
jsonFields: true,
58-
arrayFields: true
58+
arrayFields: true,
59+
queryFilters: true,
60+
queryAggregations: true,
61+
querySorting: true,
62+
queryPagination: true,
63+
queryWindowFunctions: true,
64+
querySubqueries: true
5965
};
6066

6167
private knex: Knex;

packages/foundation/types/src/driver.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,12 @@ export interface Driver {
7272
fullTextSearch?: boolean;
7373
jsonFields?: boolean;
7474
arrayFields?: boolean;
75+
queryFilters?: boolean;
76+
queryAggregations?: boolean;
77+
querySorting?: boolean;
78+
queryPagination?: boolean;
79+
queryWindowFunctions?: boolean;
80+
querySubqueries?: boolean;
7581
};
7682

7783
// Core CRUD methods (existing)

packages/objectstack/spec/src/index.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -287,6 +287,12 @@ export interface DriverInterface {
287287
fullTextSearch?: boolean;
288288
jsonFields?: boolean;
289289
arrayFields?: boolean;
290+
queryFilters?: boolean;
291+
queryAggregations?: boolean;
292+
querySorting?: boolean;
293+
queryPagination?: boolean;
294+
queryWindowFunctions?: boolean;
295+
querySubqueries?: boolean;
290296
};
291297
/** Connect to the database */
292298
connect?(): Promise<void>;

0 commit comments

Comments
 (0)