Merge pull request #416 from objectstack-ai/copilot/fix-test-errors

Author: hotlong

ROADMAP.md

@@ -88,6 +88,7 @@ ObjectQL is the **Standard Protocol for AI Software Generation** — a universal
 - ✅ 67 documentation files (.mdx) across 12 sections
 - ✅ `@objectql/driver-turso` — Turso/libSQL driver (Phase A: Core Driver) with 125 tests, 3 connection modes (remote, local, embedded replica)
 - ✅ `@objectql/driver-turso` — Phase B: Multi-Tenant Router, Schema Diff Engine, Platform API Client, Driver Plugin (52 new tests, 177 total)
+- ✅ Fix test quality: replaced all `expect(true).toBe(true)` placeholder assertions with meaningful state checks across `plugin-optimizations`, `protocol-odata-v4`, `protocol-json-rpc`, and `protocol-graphql` (7 files, 10 assertions fixed)
 
 ---
 

packages/foundation/plugin-optimizations/test/optimizations.test.ts

@@ -700,8 +700,9 @@ describe('SQLQueryOptimizer', () => {
                 fields: { name: { type: 'text' } },
                 indexes: [{ name: 'idx_name', fields: ['name'], unique: false }],
             });
-            // No error is the assertion
-            expect(true).toBe(true);
+            // Verify the schema was registered by observing optimize behavior
+            const sql = optimizer.optimize({ object: 'accounts' });
+            expect(sql).toContain('accounts');
         });
     });
 

packages/protocols/graphql/src/index.test.ts

@@ -65,8 +65,8 @@ describe('GraphQLPlugin', () => {
     it('should install successfully', async () => {
       await plugin.install?.({ engine: kernel });
 
-      // Plugin should be installed without errors
-      expect(true).toBe(true);
+      // Verify the engine reference was stored after installation
+      expect((plugin as any).engine).toBeDefined();
     });
   });
 

packages/protocols/graphql/src/integration.test.ts

@@ -298,12 +298,11 @@ describe('GraphQL Protocol Integration Tests', () => {
     describe('Error Handling', () => {
         it('should handle invalid object name', async () => {
             try {
-                await kernel.repository.find('nonexistent', {});
-                // If no error is thrown, the test should still pass
-                // as some drivers may return empty results
-                expect(true).toBe(true);
+                const result = await kernel.repository.find('nonexistent', {});
+                // Driver returns an empty array for unknown collections
+                expect(Array.isArray(result)).toBe(true);
             } catch (error) {
-                // Error is also acceptable
+                // Error is also acceptable — some drivers throw for unknown objects
                 expect(error).toBeDefined();
             }
         });

packages/protocols/json-rpc/src/index.test.ts

@@ -66,21 +66,21 @@ describe('JSONRPCPlugin', () => {
     it('should install successfully', async () => {
       await plugin.install?.({ engine: kernel });
 
-      // Plugin should be installed without errors
-      expect(true).toBe(true);
+      // Verify the engine reference was stored after installation
+      expect((plugin as any).engine).toBeDefined();
     });
 
     it('should start and stop successfully', async () => {
       await plugin.install?.({ engine: kernel });
       await plugin.onStart?.({ engine: kernel });
 
-      // Plugin should start without errors
-      expect(true).toBe(true);
+      // Verify the HTTP server was created and is listening
+      expect((plugin as any).server?.listening).toBe(true);
 
       await plugin.onStop?.({ engine: kernel });
 
-      // Plugin should stop without errors
-      expect(true).toBe(true);
+      // Verify the HTTP server stopped accepting connections
+      expect((plugin as any).server?.listening).toBe(false);
     });
   });
 

packages/protocols/json-rpc/src/integration.test.ts

@@ -290,8 +290,9 @@ describe('JSON-RPC 2.0 Protocol Integration Tests', () => {
         it('should handle method not found (-32601)', async () => {
             try {
                 // Simulate calling non-existent method
-                await kernel.repository.find('nonexistent', {});
-                expect(true).toBe(true); // Driver may return empty
+                const result = await kernel.repository.find('nonexistent', {});
+                // Driver returns empty array for unknown collections
+                expect(Array.isArray(result)).toBe(true);
             } catch (error) {
                 expect(error).toBeDefined();
             }
@@ -311,11 +312,11 @@ describe('JSON-RPC 2.0 Protocol Integration Tests', () => {
 
         it('should handle application errors', async () => {
             try {
-                await kernel.repository.update('tasks', 'non-existent', {
+                const result = await kernel.repository.update('tasks', 'non-existent', {
                     title: 'Updated'
                 });
-                // May return null or throw
-                expect(true).toBe(true);
+                // MemoryDriver returns null for non-existent records in non-strict mode
+                expect(result).toBeNull();
             } catch (error) {
                 expect(error).toBeDefined();
             }
@@ -559,17 +560,19 @@ describe('JSON-RPC 2.0 Protocol Integration Tests', () => {
     describe('Error Handling and Recovery', () => {
         it('should handle null parameters gracefully', async () => {
             try {
-                await kernel.repository.find('tasks', null as any);
-                expect(true).toBe(true);
+                const result = await kernel.repository.find('tasks', null as any);
+                // Driver handles null query gracefully — returns records or empty array
+                expect(result).toBeDefined();
             } catch (error) {
                 expect(error).toBeDefined();
             }
         });
 
         it('should handle empty object name', async () => {
             try {
-                await kernel.repository.find('', {});
-                expect(true).toBe(true);
+                const result = await kernel.repository.find('', {});
+                // Driver returns empty array for unknown/empty collection names
+                expect(Array.isArray(result)).toBe(true);
             } catch (error) {
                 expect(error).toBeDefined();
             }

packages/protocols/odata-v4/src/index.test.ts

@@ -67,21 +67,21 @@ describe('ODataV4Plugin', () => {
     it('should install successfully', async () => {
       await plugin.install?.({ engine: kernel });
 
-      // Plugin should be installed without errors
-      expect(true).toBe(true);
+      // Verify the engine reference was stored after installation
+      expect((plugin as any).engine).toBeDefined();
     });
 
     it('should start and stop successfully', async () => {
       await plugin.install?.({ engine: kernel });
       await plugin.onStart?.({ engine: kernel });
 
-      // Plugin should start without errors
-      expect(true).toBe(true);
+      // Verify the HTTP server was created and is listening
+      expect((plugin as any).server).toBeDefined();
 
       await plugin.onStop?.({ engine: kernel });
 
-      // Plugin should stop without errors
-      expect(true).toBe(true);
+      // Verify the HTTP server was torn down
+      expect((plugin as any).server).toBeUndefined();
     });
   });
 

packages/protocols/odata-v4/src/integration.test.ts

@@ -385,9 +385,9 @@ describe('OData V4 Protocol Integration Tests', () => {
     describe('Error Response Format', () => {
         it('should handle invalid entity set', async () => {
             try {
-                await kernel.repository.find('NonExistent', {});
-                // If no error, that's fine - driver returns empty
-                expect(true).toBe(true);
+                const result = await kernel.repository.find('NonExistent', {});
+                // Driver returns an empty array for unknown collections
+                expect(Array.isArray(result)).toBe(true);
             } catch (error: any) {
                 // Error should have proper structure
                 expect(error).toBeDefined();
@@ -421,8 +421,9 @@ describe('OData V4 Protocol Integration Tests', () => {
         it('should handle malformed requests', async () => {
             try {
                 // Pass invalid query format
-                await kernel.repository.find('Products', null as any);
-                expect(true).toBe(true);
+                const result = await kernel.repository.find('Products', null as any);
+                // Driver handles null query gracefully — returns records or empty array
+                expect(result).toBeDefined();
             } catch (error) {
                 expect(error).toBeDefined();
             }