Merge pull request #346 from objectstack-ai/copilot/fix-action-step-failure

Author: hotlong

packages/foundation/core/src/app.ts

@@ -110,18 +110,24 @@ export class ObjectQL implements IObjectQL {
                 return items.map(unwrapContent);
             },
             unregister: (type: string, name: string) => {
-                 // Access private static storage using any cast
-                 const metadata = (SchemaRegistry as any).metadata;
-                 if (metadata instanceof Map) {
-                     const collection = metadata.get(type);
-                     if (collection instanceof Map) {
-                         collection.delete(name);
+                 // Use the official unregisterItem API when available (added in @objectstack/objectql v0.9.2)
+                 // Fallback to direct metadata access for older versions or test mocks
+                 if (typeof SchemaRegistry.unregisterItem === 'function') {
+                     SchemaRegistry.unregisterItem(type, name);
+                 } else {
+                     // Fallback: try to access metadata Map directly
+                     const metadata = (SchemaRegistry as any).metadata;
+                     if (metadata && metadata instanceof Map) {
+                         const collection = metadata.get(type);
+                         if (collection && collection instanceof Map) {
+                             collection.delete(name);
+                         }
                      }
                  }
             },
             unregisterPackage: (packageName: string) => {
                  const metadata = (SchemaRegistry as any).metadata;
-                 if (metadata instanceof Map) {
+                 if (metadata && metadata instanceof Map) {
                      for (const [type, collection] of metadata.entries()) {
                          if (collection instanceof Map) {
                              for (const [key, item] of collection.entries()) {
@@ -395,6 +401,21 @@ export class ObjectQL implements IObjectQL {
             await (this.kernel as any).bootstrap();
         } else {
              console.warn('ObjectKernel does not have start() or bootstrap() method');
+             
+             // Manually initialize plugins if kernel doesn't support lifecycle
+             for (const plugin of this.kernelPlugins) {
+                 try {
+                     if (typeof (plugin as any).init === 'function') {
+                         await (plugin as any).init();
+                     }
+                     if (typeof (plugin as any).start === 'function') {
+                         await (plugin as any).start();
+                     }
+                 } catch (error) {
+                     console.error(`Failed to initialize plugin ${(plugin as any).name || 'unknown'}:`, error);
+                     // Continue with other plugins even if one fails
+                 }
+             }
         }
 
         // TEMPORARY: Set driver for backward compatibility during migration

packages/foundation/core/test/__mocks__/@objectstack/objectql.ts

@@ -28,12 +28,18 @@ export const SchemaRegistry = {
     const key = item[keyField];
     mockStore.get(type)!.set(key, item);
   }),
+  unregisterItem: jest.fn((type: string, name: string) => {
+    const collection = mockStore.get(type);
+    if (collection) {
+      collection.delete(name);
+    }
+  }),
   getItem: jest.fn((type: string, name: string) => {
     return mockStore.get(type)?.get(name);
   }),
   listItems: jest.fn((type: string) => {
     const items = mockStore.get(type);
     return items ? Array.from(items.values()) : [];
   }),
-  metadata: {},
+  metadata: mockStore,
 };