Commit 0076683
committed
fix(client-react): typecheck the package's own tests instead of excluding them
`check:type-check-coverage` failed on the first push, and it was right. The
initial commit added `**/*.test.tsx` to tsconfig's `exclude` to match the
`**/*.test.ts` entry every sibling package carries — but that entry is frozen
DEBT the repo is migrating away from (#4311), not a convention to copy. The
gate's own summary makes it explicit: 21 packages still exclude their tests,
carrying 2243 frozen raw errors in TEST_DEBT. Excluding one more would have
reported green over source `tsc` never read.
Drops the test exclusion entirely, so client-react typechecks its own tests and
stays out of that ledger.
Doing so immediately surfaced a real gap: the `METADATA_EVENT` fixture was
declared and never used, because `useMetadataSubscription` was covered for
re-subscription and unmount but not for delivery. Adds that assertion rather
than deleting the fixture — 18 tests now.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LYnZrTwXbrctB8E8HpJAPT1 parent 97dbfb2 commit 0076683
2 files changed
Lines changed: 14 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
329 | 329 | | |
330 | 330 | | |
331 | 331 | | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
332 | 345 | | |
333 | 346 | | |
334 | 347 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
14 | 14 | | |
0 commit comments