Skip to content

Commit 08646aa

Browse files
Copilothotlong
andcommitted
fix: address code review feedback - improve browser detection and docs
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
1 parent b5f4ade commit 08646aa

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

packages/plugins/driver-memory/src/memory-driver.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -928,7 +928,7 @@ export class InMemoryDriver implements DriverInterface {
928928
* Detect whether the current runtime is a browser environment.
929929
*/
930930
private isBrowserEnvironment(): boolean {
931-
return typeof window !== 'undefined' && typeof window.localStorage !== 'undefined';
931+
return typeof globalThis.localStorage !== 'undefined';
932932
}
933933

934934
/**

packages/spec/src/data/driver/memory.zod.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ export const AutoPersistenceConfigSchema = z.object({
9898
type: z.literal('auto'),
9999
/** File path override when running in Node.js. */
100100
path: z.string().optional().describe('File path override for Node.js environments'),
101-
/** Auto-save interval override when running in Node.js. Default: 2000ms. */
101+
/** Auto-save interval override when running in Node.js. */
102102
autoSaveInterval: z.number().min(100).optional().describe('Auto-save interval override for Node.js environments'),
103103
/** localStorage key override when running in a browser. */
104104
key: z.string().optional().describe('localStorage key override for browser environments'),

0 commit comments

Comments
 (0)