Skip to content

Commit 108cb93

Browse files
Copilothotlong
andcommitted
fix: correct ESM/CJS export paths for "type": "module" service packages
When tsup builds a package with "type": "module", it outputs: - ESM → dist/index.js (not .mjs) - CJS → dist/index.cjs (not .js) All 8 service packages had the wrong export paths (using .mjs/.js convention intended for packages WITHOUT "type": "module"), causing ERR_MODULE_NOT_FOUND on Vercel when importing @objectstack/service-feed. Fixes: service-feed, service-automation, service-cache, service-realtime, service-job, service-queue, service-storage, service-analytics. Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com> Agent-Logs-Url: https://github.com/objectstack-ai/spec/sessions/584d6e41-6f6f-493b-8c7b-7634aadaa08f
1 parent 20c038c commit 108cb93

9 files changed

Lines changed: 24 additions & 16 deletions

File tree

CHANGELOG.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
88
## [Unreleased]
99

1010
### Fixed
11+
- **Vercel deployment — `ERR_MODULE_NOT_FOUND` for `@objectstack/service-feed`** — Fixed incorrect
12+
`exports` paths in `package.json` for all service packages that declare `"type": "module"`. When
13+
`tsup` builds an ESM package (`"type": "module"`), it outputs `.js` for ESM and `.cjs` for CJS.
14+
However, the exports maps incorrectly referenced `.mjs` (ESM) and `.js` (CJS) — the convention
15+
for packages *without* `"type": "module"`. This caused Node's ESM resolver to fail with
16+
`ERR_MODULE_NOT_FOUND` when Vercel tried to import `dist/index.mjs` (which doesn't exist).
17+
Affected packages: `service-feed`, `service-automation`, `service-cache`, `service-realtime`,
18+
`service-job`, `service-queue`, `service-storage`, `service-analytics`.
1119
- **`@objectstack/driver-sql` DTS build failure — knex type resolution** — Fixed a TypeScript
1220
declaration build failure caused by knex v3.2.3 declaring a non-existent `.d.mts` types file
1321
in its package.json `exports` field. With `moduleResolution: "bundler"`, TypeScript could not

packages/services/service-analytics/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99
"exports": {
1010
".": {
1111
"types": "./dist/index.d.ts",
12-
"import": "./dist/index.mjs",
13-
"require": "./dist/index.js"
12+
"import": "./dist/index.js",
13+
"require": "./dist/index.cjs"
1414
}
1515
},
1616
"scripts": {

packages/services/service-automation/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99
"exports": {
1010
".": {
1111
"types": "./dist/index.d.ts",
12-
"import": "./dist/index.mjs",
13-
"require": "./dist/index.js"
12+
"import": "./dist/index.js",
13+
"require": "./dist/index.cjs"
1414
}
1515
},
1616
"scripts": {

packages/services/service-cache/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99
"exports": {
1010
".": {
1111
"types": "./dist/index.d.ts",
12-
"import": "./dist/index.mjs",
13-
"require": "./dist/index.js"
12+
"import": "./dist/index.js",
13+
"require": "./dist/index.cjs"
1414
}
1515
},
1616
"scripts": {

packages/services/service-feed/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99
"exports": {
1010
".": {
1111
"types": "./dist/index.d.ts",
12-
"import": "./dist/index.mjs",
13-
"require": "./dist/index.js"
12+
"import": "./dist/index.js",
13+
"require": "./dist/index.cjs"
1414
}
1515
},
1616
"scripts": {

packages/services/service-job/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99
"exports": {
1010
".": {
1111
"types": "./dist/index.d.ts",
12-
"import": "./dist/index.mjs",
13-
"require": "./dist/index.js"
12+
"import": "./dist/index.js",
13+
"require": "./dist/index.cjs"
1414
}
1515
},
1616
"scripts": {

packages/services/service-queue/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99
"exports": {
1010
".": {
1111
"types": "./dist/index.d.ts",
12-
"import": "./dist/index.mjs",
13-
"require": "./dist/index.js"
12+
"import": "./dist/index.js",
13+
"require": "./dist/index.cjs"
1414
}
1515
},
1616
"scripts": {

packages/services/service-realtime/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99
"exports": {
1010
".": {
1111
"types": "./dist/index.d.ts",
12-
"import": "./dist/index.mjs",
13-
"require": "./dist/index.js"
12+
"import": "./dist/index.js",
13+
"require": "./dist/index.cjs"
1414
}
1515
},
1616
"scripts": {

packages/services/service-storage/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99
"exports": {
1010
".": {
1111
"types": "./dist/index.d.ts",
12-
"import": "./dist/index.mjs",
13-
"require": "./dist/index.js"
12+
"import": "./dist/index.js",
13+
"require": "./dist/index.cjs"
1414
}
1515
},
1616
"scripts": {

0 commit comments

Comments
 (0)