Fix code review feedback: standardize protocol conventions, guard name overwrite

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>

Author: Copilot

packages/objectql/src/metadata-facade.ts

@@ -17,7 +17,9 @@ export class MetadataFacade {
    * Register a metadata item
    */
   async register(type: string, name: string, data: any): Promise<void> {
-    const definition = typeof data === 'object' && data !== null ? { ...data, name } : data;
+    const definition = typeof data === 'object' && data !== null
+      ? { ...data, name: data.name ?? name }
+      : data;
     if (type === 'object') {
       SchemaRegistry.registerItem(type, definition, 'name' as any);
     } else {

packages/spec/src/kernel/metadata-loader.test.ts

@@ -332,7 +332,7 @@ describe('MetadataLoaderProtocol', () => {
     it('should validate loader contract', () => {
       const contract = {
         name: 'filesystem',
-        protocol: 'file',
+        protocol: 'file:',
         capabilities: {
           read: true,
           write: true,
@@ -344,7 +344,7 @@ describe('MetadataLoaderProtocol', () => {
 
       const validated = MetadataLoaderContractSchema.parse(contract);
       expect(validated.name).toBe('filesystem');
-      expect(validated.protocol).toBe('file');
+      expect(validated.protocol).toBe('file:');
       expect(validated.supportsWatch).toBe(false); // default
       expect(validated.supportsWrite).toBe(true); // default
       expect(validated.supportsCache).toBe(true); // default
@@ -353,7 +353,7 @@ describe('MetadataLoaderProtocol', () => {
     it('should allow custom capabilities', () => {
       const contract = {
         name: 'http',
-        protocol: 'http',
+        protocol: 'http:',
         capabilities: {
           read: true,
           write: false,
@@ -367,26 +367,26 @@ describe('MetadataLoaderProtocol', () => {
       };
 
       const validated = MetadataLoaderContractSchema.parse(contract);
-      expect(validated.protocol).toBe('http');
+      expect(validated.protocol).toBe('http:');
       expect(validated.supportsWrite).toBe(false);
       expect(validated.supportsCache).toBe(true);
     });
 
     it('should accept datasource protocol', () => {
       const contract = {
         name: 'database',
-        protocol: 'datasource',
+        protocol: 'datasource:',
         capabilities: { read: true, write: true, watch: false, list: true },
         supportedFormats: ['json'] as const,
       };
 
       const validated = MetadataLoaderContractSchema.parse(contract);
-      expect(validated.protocol).toBe('datasource');
+      expect(validated.protocol).toBe('datasource:');
       expect(validated.capabilities.write).toBe(true);
     });
 
     it('should accept all valid protocols', () => {
-      const protocols = ['file', 'http', 's3', 'datasource'];
+      const protocols = ['file:', 'http:', 's3:', 'datasource:'];
       protocols.forEach((protocol) => {
         expect(() => MetadataLoaderContractSchema.parse({
           name: 'test', protocol, capabilities: {}, supportedFormats: ['json'],
@@ -396,7 +396,7 @@ describe('MetadataLoaderProtocol', () => {
 
     it('should reject invalid protocol', () => {
       expect(() => MetadataLoaderContractSchema.parse({
-        name: 'test', protocol: 'ftp', capabilities: {}, supportedFormats: ['json'],
+        name: 'test', protocol: 'ftp:', capabilities: {}, supportedFormats: ['json'],
       })).toThrow();
     });
   });

packages/spec/src/kernel/metadata-loader.zod.ts

@@ -372,9 +372,9 @@ export const MetadataLoaderContractSchema = z.object({
   name: z.string().describe('Loader identifier'),
 
   /**
-   * Protocol handled by this loader (e.g. 'file', 'http', 's3', 'datasource')
+   * Protocol handled by this loader (e.g. 'file:', 'http:', 's3:', 'datasource:')
    */
-  protocol: z.enum(['file', 'http', 's3', 'datasource']).describe('Protocol identifier'),
+  protocol: z.enum(['file:', 'http:', 's3:', 'datasource:']).describe('Protocol identifier'),
 
   /**
    * Detailed capabilities