Skip to content

Commit 1e29dcd

Browse files
os-zhuangclaude
andcommitted
fix(create-objectstack): exclude CHANGELOG.md from the skills-catalog-boundary ratchet (main red)
The `no customer-facing surface advertises a repo-root skills install` guard (template-consistency.test.ts) grepped `content/docs`/`skills`/ `packages/create-objectstack` for `skills add objectstack-ai/framework` not followed by `/skills`, excluding only the test file — not CHANGELOG.md. When Changesets versioned create-objectstack in RC mode, it baked #3101's changeset prose into packages/create-objectstack/CHANGELOG.md. That entry documents the fix by quoting the removed command in past tense ("…advertised `skills add objectstack-ai/framework --all` … now scoped to the /skills subpath"), which tripped the ratchet and turned Test Core red on main (pre-existing; first seen at e412fb6 / 631deba, before any of my changes). A CHANGELOG documenting the REMOVAL of an anti-pattern is not advertising it — only real customer-facing surfaces (docs, README, index.ts, AGENTS.md, which all correctly use the /skills subpath) should count. Exclude `**/CHANGELOG.md` from the guard's grep surfaces. Test-only change; no shipped behavior. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1 parent 8efa395 commit 1e29dcd

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

packages/create-objectstack/src/template-consistency.test.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -318,6 +318,12 @@ describe('skills catalog boundary', () => {
318318
'packages/create-objectstack',
319319
// this file mentions the bare form on purpose (needle + error message)
320320
':(exclude)packages/create-objectstack/src/template-consistency.test.ts',
321+
// CHANGELOGs are auto-generated from changeset prose and legitimately
322+
// quote a removed command in past tense while documenting its removal
323+
// (#3101: "…advertised `skills add objectstack-ai/framework --all` … now
324+
// scoped to the /skills subpath"). Documenting a fix is not advertising
325+
// the anti-pattern — only real customer-facing surfaces count.
326+
':(exclude)**/CHANGELOG.md',
321327
];
322328
let candidates = '';
323329
try {

0 commit comments

Comments
 (0)