Skip to content

Commit 20bfa29

Browse files
committed
revert(showcase): drop unverified stageField kanban dogfood views
The two board views didn't resolve via the console's ?view= path (top-level defineView boards don't land in objectDef.listViews and the objects aren't in the app nav), so the browser assertion couldn't reliably verify them. The kanban default-lane behavior (objectui#2596) is already covered by that PR's unit tests plus semantic-roles.dogfood.test.ts (which proves stageField:'status' and stageField:false serve correctly — the exact inputs the console's detector consumes). Keeping only the pin bump. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016wpaFMPowSn4nAWsjeGZib
1 parent d79383c commit 20bfa29

4 files changed

Lines changed: 2 additions & 62 deletions

File tree

examples/app-showcase/e2e/detail-shapes.spec.ts

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -137,27 +137,6 @@ test('stageField:false: status renders as a plain field, no stepper', async ({ p
137137
expect(errors, 'uncaught page errors on stageField:false detail').toEqual([]);
138138
});
139139

140-
test('kanban default lanes honour stageField — role drives lanes, strict-false suppresses them', async ({ page }) => {
141-
// Both `board` views deliberately carry NO kanban binding (spec-optional),
142-
// so the lane field resolves through the shared stageField detector
143-
// (objectui#2596).
144-
145-
// Positive: zoo declares stageField:'status' → lanes are the option
146-
// labels, with zero view-level config.
147-
let errors = await openRecord(page, `/_console/apps/${APP}/showcase_semantic_zoo?view=board`);
148-
await expect(page.getByText('Draft', { exact: true }).first()).toBeVisible();
149-
await expect(page.getByText('Done', { exact: true }).first()).toBeVisible();
150-
expect(errors, 'uncaught page errors on stageField board').toEqual([]);
151-
152-
// Negative: legacy zoo declares stageField:false (its status is a color,
153-
// not a lifecycle) → NO default lanes. The pre-#2596 hard-coded 'status'
154-
// fallback would have grouped by Red / Green.
155-
errors = await openRecord(page, `/_console/apps/${APP}/showcase_semantic_zoo_legacy?view=board`);
156-
await expect(page.getByText('Red', { exact: true })).toHaveCount(0);
157-
await expect(page.getByText('Green', { exact: true })).toHaveCount(0);
158-
expect(errors, 'uncaught page errors on suppressed board').toEqual([]);
159-
});
160-
161140
test('ungrouped + related-heavy: flat details and related-list tabs on Contoso', async ({ page }) => {
162141
const errors = await openRecord(page, recordUrl('showcase_account', contosoId));
163142

examples/app-showcase/objectstack.config.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import { ExternalCustomer, ExternalOrder } from './src/data/objects/external/ind
1818
import { setupShowcaseExternalDatasource } from './src/system/datasources/external-fixture.js';
1919
import { registerRecalcEndpoint } from './src/system/server/recalc-endpoint.js';
2020
import { registerShowcasePositionBindings } from './src/security/bind-position-sets.js';
21-
import { TaskViews, ProjectViews, InquiryViews, BusinessUnitViews, SemanticZooViews, SemanticZooLegacyViews } from './src/ui/views/index.js';
21+
import { TaskViews, ProjectViews, InquiryViews, BusinessUnitViews } from './src/ui/views/index.js';
2222
import { ShowcaseApp } from './src/ui/apps/index.js';
2323
import { ChartGalleryDashboard, OpsDashboard, RevenuePulseDashboard } from './src/ui/dashboards/index.js';
2424
import { ShowcaseTaskDataset, ShowcaseProjectDataset, ShowcaseInvoiceDataset, ShowcaseAccountDataset } from './src/ui/datasets/index.js';
@@ -181,7 +181,7 @@ export default defineStack({
181181
// UI
182182
apps: [ShowcaseApp],
183183
portals: allPortals,
184-
views: [TaskViews, ProjectViews, InquiryViews, BusinessUnitViews, SemanticZooViews, SemanticZooLegacyViews],
184+
views: [TaskViews, ProjectViews, InquiryViews, BusinessUnitViews],
185185
pages: [CapabilityMapPage, StartHerePage, ComponentGalleryPage, ProjectWorkspacePage, ProjectDetailPage, TaskWorkbenchPage, TaskTriagePage, TaskBoardPage, TaskCalendarPage, TaskGalleryPage, TaskSchedulePage, TaskTimelinePage, TaskMapPage, TaskAllViewsPage, ActiveProjectsPage, TaskDetailPage, ReviewQueuePage, NewProjectWizardPage, MyWorkPage, SettingsPage, StylingGalleryPage, CommandCenterPage, CommandCenterJsxPage, CrmWorkbenchPage, TaskDeskPage, PageVariablesPage, ContactFormPage, RenewalsPipelinePage],
186186
dashboards: [ChartGalleryDashboard, OpsDashboard, RevenuePulseDashboard],
187187
books: allBooks,

examples/app-showcase/src/ui/views/index.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,3 @@ export { ProjectViews } from './project.view.js';
55
export { InquiryViews } from './inquiry.view.js';
66
export { BusinessUnitViews } from './business-unit.view.js';
77
export { ContactViews } from './contact.view.js';
8-
export { SemanticZooViews, SemanticZooLegacyViews } from './semantic-zoo.view.js';

examples/app-showcase/src/ui/views/semantic-zoo.view.ts

Lines changed: 0 additions & 38 deletions
This file was deleted.

0 commit comments

Comments
 (0)