feat(lint,cli): JSX gate does full validation when a manifest is present (ADR-0080 M3b①) (#2446)

validateJsxPages accepts an optional component manifest -> compile()-based full
validation (unknown component / missing-required / enum / type); without it,
parse-level. os validate loads sdui.manifest.json from the project root when
present. Generating+shipping that manifest from the registry public tier stays a
build/CI step.

Co-authored-by: Jack Zhuang <277994282+os-zhuang@users.noreply.github.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

Author: os-zhuang

.changeset/sdui-jsx-gate-manifest.md

@@ -0,0 +1,6 @@
+---
+"@objectstack/lint": minor
+"@objectstack/cli": minor
+---
+
+ADR-0080 M3b① (consumption seam): the `os build` / `os validate` JSX gate now does **full component/prop validation** (unknown component, missing/wrong prop, bad enum, bindings) when a `sdui.manifest.json` is present at the project root — falling back to parse-level otherwise. `validateJsxPages` accepts an optional manifest; the validate command loads the file when present. Generating + shipping that manifest from the registry's public tier remains a build/CI step.

packages/cli/src/commands/validate.ts

@@ -1,6 +1,8 @@
 // Copyright (c) 2025 ObjectStack. Licensed under the Apache-2.0 license.
 
 import { Args, Command, Flags } from '@oclif/core';
+import { existsSync, readFileSync } from 'node:fs';
+import { join } from 'node:path';
 import chalk from 'chalk';
 import { ZodError } from 'zod';
 import { ObjectStackDefinitionSchema, normalizeStackInput } from '@objectstack/spec';
@@ -170,7 +172,18 @@ export default class Validate extends Command {
       //     time. Parse it now so malformed source fails loudly (ADR-0078)
       //     instead of being stored and breaking only at render.
       if (!flags.json) printStep('Checking JSX-source pages (ADR-0080)...');
-      const jsxFindings = validateJsxPages(result.data as Record<string, unknown>);
+      // Optional component manifest (ADR-0080): if the project ships a
+      // `sdui.manifest.json` (generated from the registry's public tier), the
+      // gate does full component/prop validation; otherwise parse-level.
+      let sduiManifest: unknown;
+      try {
+        const mp = join(process.cwd(), 'sdui.manifest.json');
+        if (existsSync(mp)) sduiManifest = JSON.parse(readFileSync(mp, 'utf8'));
+      } catch { /* fall back to parse-level */ }
+      const jsxFindings = validateJsxPages(
+        result.data as Record<string, unknown>,
+        sduiManifest ? { manifest: sduiManifest as never } : {},
+      );
       const jsxErrors = jsxFindings.filter((f) => f.severity === 'error');
       const jsxWarnings = jsxFindings.filter((f) => f.severity === 'warning');
 

packages/lint/src/validate-jsx-pages.test.ts

@@ -24,3 +24,22 @@ describe('validateJsxPages (ADR-0080 build gate)', () => {
     expect(validateJsxPages({ pages: [{ name: 'full', kind: 'full', regions: [] }] })).toEqual([]);
   });
 });
+
+describe('validateJsxPages — full validation with a manifest', () => {
+  const manifest = {
+    components: {
+      flex: { type: 'flex', namespace: 'ui', isContainer: true, inputs: [] },
+      'object-table': { type: 'object-table', namespace: 'plugin-grid', inputs: [{ name: 'object', type: 'string', required: true }] },
+    },
+  };
+  it('catches unknown components and missing required props', () => {
+    const stack = { pages: [{ name: 'cc', kind: 'jsx', source: '<flex><object-table /><bogus /></flex>' }] };
+    const f = validateJsxPages(stack, { manifest } as never);
+    expect(f.some((x) => x.rule === 'jsx-missing-required-prop')).toBe(true);
+    expect(f.some((x) => x.rule === 'jsx-forbidden-tag')).toBe(true);
+  });
+  it('passes when components + required props are satisfied', () => {
+    const stack = { pages: [{ name: 'cc', kind: 'jsx', source: '<flex><object-table object="account" /></flex>' }] };
+    expect(validateJsxPages(stack, { manifest } as never)).toEqual([]);
+  });
+});

packages/lint/src/validate-jsx-pages.ts

@@ -14,7 +14,7 @@
 // thread it through `compile()` here. Until then this catches the structural
 // class of error an AI author is most likely to emit.
 
-import { parseJsx } from '@objectstack/sdui-parser';
+import { parseJsx, compile, type Manifest } from '@objectstack/sdui-parser';
 
 export type JsxPageSeverity = 'error' | 'warning';
 
@@ -32,7 +32,7 @@ export interface JsxPageFinding {
 type AnyRec = Record<string, unknown>;
 const asArray = (v: unknown): AnyRec[] => (Array.isArray(v) ? (v as AnyRec[]) : []);
 
-export function validateJsxPages(stack: AnyRec): JsxPageFinding[] {
+export function validateJsxPages(stack: AnyRec, opts: { manifest?: Manifest } = {}): JsxPageFinding[] {
   const findings: JsxPageFinding[] = [];
   const pages = asArray(stack.pages);
   for (let p = 0; p < pages.length; p++) {
@@ -52,7 +52,9 @@ export function validateJsxPages(stack: AnyRec): JsxPageFinding[] {
       });
       continue;
     }
-    const { diagnostics } = parseJsx(source);
+    // With a component manifest, do full validation (unknown component, missing/
+    // wrong prop, bad enum, bindings); without it, parse-level (syntax/structure).
+    const { diagnostics } = opts.manifest ? compile(source, opts.manifest) : parseJsx(source);
     for (const d of diagnostics) {
       findings.push({
         severity: d.severity,