Skip to content

Commit 252c526

Browse files
committed
skills(platform): excise the nonexistent data:* hook system; fix fabricated surface
Third-party review found the skill's core plugin-development narrative teaching a data:* kernel hook system that does not exist in the codebase — ctx.hook() accepts any string, so handlers registered against data:beforeInsert etc. silently never fire (the worst failure mode). Also fabricated wholesale: six adapter packages, three driver packages, three scaffold templates, and the Part-3 testing API. - data:* excised from four files; replaced with the real kernel events (kernel:ready|bootstrapped|listening|shutdown, app:seeded, metadata:reloaded, external.schema.drift) with payloads read from the actual trigger sites, plus a prominent record-lifecycle-belongs-to- objectstack-data cross-reference. metadata:changed → metadata:reloaded. - Adapters: only @objectstack/hono + @objectstack/plugin-hono-server exist. Drivers: driver-memory/driver-sql (SqlDriver via Knex)/ driver-mongodb/driver-sqlite-wasm; driver-turso marked cloud/EE-only; driver-postgres/-sqlite/-d1 and SQLiteDriver/PostgreSQLDriver removed. - Templates corrected to blank|todo|compliance|content|contracts| procurement; LiteKernel testing rewritten to the real surface (use/bootstrap/getService — no create/api/seed/reset). - defineStack key list regenerated from ObjectStackDefinitionSchema (41 keys; workflows/approvals/ragPipelines/roles/policies/driver/ logging are silently-stripped phantoms — ADR-0019/0020 noted); bootstrap-patterns.md rewritten around DriverPlugin + a valid manifest (id/version/type/name required). - CLI truth: no os studio / os data seed / os meta apply; os diff/ cloud/start/info descriptions corrected; /health + /ready; Console mounts at /_console/ (studio plugin intentionally not default- loaded); HonoServerPlugin registers before AuthPlugin; port 3000. - Service registry: required key is data; REST plugin id com.objectstack.rest.api registers no service; registerService throws on duplicate; fallbacks are createMemory* factories; null-placeholder anti-pattern removed; deps at ^16.0.0-rc.1 mirroring the blank template; evals README rewritten for platform. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012Kj2MJEPXoUXC4LiC3XYJc
1 parent 57f2e2c commit 252c526

7 files changed

Lines changed: 547 additions & 574 deletions

File tree

skills/objectstack-platform/SKILL.md

Lines changed: 200 additions & 169 deletions
Large diffs are not rendered by default.

skills/objectstack-platform/evals/README.md

Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -12,17 +12,20 @@ When implemented, evals will follow this structure:
1212

1313
```
1414
evals/
15-
├── naming/
16-
│ ├── test-object-names.md
17-
│ ├── test-field-keys.md
18-
│ └── test-option-values.md
19-
├── relationships/
20-
│ ├── test-lookup-vs-master-detail.md
21-
│ └── test-junction-patterns.md
22-
├── validation/
23-
│ ├── test-script-inversion.md
24-
│ └── test-state-machine.md
25-
└── ...
15+
├── bootstrap/
16+
│ ├── test-definestack-keys.md # no phantom keys (driver:, workflows:, roles:)
17+
│ ├── test-manifest-required-fields.md
18+
│ └── test-template-selection.md # blank | todo | compliance | content | contracts | procurement
19+
├── drivers-adapters/
20+
│ ├── test-driver-selection.md # memory / sql / mongodb / sqlite-wasm; turso = cloud/EE
21+
│ └── test-hono-integration.md # @objectstack/hono vs plugin-hono-server; no adapter-*
22+
├── plugins/
23+
│ ├── test-lifecycle-phases.md # init/start/destroy, dependency order
24+
│ ├── test-service-registry.md # registerService throws on duplicate; no null placeholders
25+
│ └── test-kernel-events.md # kernel:ready/bootstrapped/listening/shutdown; NO data:* events
26+
└── ops/
27+
├── test-cli-commands.md # real command surface (no os studio / os data seed / os meta apply)
28+
└── test-litekernel-testing.md # new LiteKernel().use(...) pattern; kernel.context is protected
2629
```
2730

2831
## Format

0 commit comments

Comments
 (0)