Skip to content

Commit 257541d

Browse files
committed
fix(guard): drop the wildcard-mount entry #4112 deleted — the guard fails on main
`scripts/check-wildcard-fallthrough.mjs` declared the hono adapter's `${prefix}/storage/*` mount, which no longer exists: ✗ wildcard fall-through guard (#4116) packages/adapters/hono/src/index.ts:all `${prefix}/storage/*` DECLARED but not found by the scan. Moved, renamed or deleted? Update MOUNTS. #4112 removed that mount outright — the adapter now carries a "deliberately NOT mounted (#4087)" note in its place — because the wildcard claimed the whole `/storage` subtree and answered its own 404 for every path `service-storage` registers under it. That is the #4088 failure actually happening, so removal was the fix rather than a ratchet. #4112 and #4122 (which added this scan) were each green on their own base and landed in that order, leaving the entry declaring a deleted mount. Reproduced on pristine origin/main, so it is not specific to any branch — and since the guard runs on every PR, it blocks all of them: git worktree add /tmp/main-check origin/main cd /tmp/main-check && node scripts/check-wildcard-fallthrough.mjs # 1 problem(s) Removes the stale entry, which is what the guard's own message asks for. The sibling `${prefix}/auth/*` entry stays: that mount is still there (packages/adapters/hono/src/index.ts:279), so its ratchet is still live. The comment above them said "Both are the #4088 shape" and is now singular, with the storage mount's removal recorded so the next reader does not have to reconstruct why one of a documented pair disappeared. Verified: `pnpm check:wildcard-fallthrough` self-test 15 cases, then 6 yielding / 1 ratcheted / 5 exempt across 12 namespace-claiming mounts. The two steps that follow it in the same CI job and never got to run — check:release-notes, check:node-version — pass too. Refs #4116, #4117, #4112 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HrRNgrWaRtggzmrHpbomyh
1 parent 6a381db commit 257541d

1 file changed

Lines changed: 14 additions & 8 deletions

File tree

scripts/check-wildcard-fallthrough.mjs

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -147,17 +147,23 @@ const MOUNTS = {
147147

148148
// ── Ratchet: real, tracked, NOT blessed ─────────────────────────────────
149149
//
150-
// Both are the #4088 shape in an adapter that no in-repo package depends on,
151-
// so nothing is broken today — but it ships, and ADR-0076's own trigger is an
152-
// out-of-tree embedder (`../objectbase`'s gateway). An embedder mounting a
153-
// route under either prefix hits exactly #4088. Found BY this scan; manual
154-
// greps for the pattern had missed both. Tracked by #4117.
150+
// The #4088 shape in an adapter that no in-repo package depends on, so nothing
151+
// is broken today — but it ships, and ADR-0076's own trigger is an out-of-tree
152+
// embedder (`../objectbase`'s gateway). An embedder mounting a route under
153+
// this prefix hits exactly #4088. Found BY this scan; manual greps for the
154+
// pattern had missed it. Tracked by #4117.
155+
//
156+
// This listed the adapter's `${prefix}/storage/*` mount too, until #4112
157+
// deleted that mount outright (see the "deliberately NOT mounted (#4087)"
158+
// note in the adapter): the wildcard claimed the whole `/storage` subtree and
159+
// answered its own 404 for every path `service-storage` registers under it —
160+
// the #4088 failure actually happening, so the fix was removal rather than a
161+
// ratchet. #4112 and the PR that added this scan (#4122) were each green on
162+
// their own base and landed in that order, which left the entry declaring a
163+
// mount that no longer existed and failed this guard on `main`.
155164
'packages/adapters/hono/src/index.ts:all `${prefix}/auth/*`': {
156165
ratchet: '#4117 — terminal, same shape as #4088; adapter has no in-repo consumer',
157166
},
158-
'packages/adapters/hono/src/index.ts:all `${prefix}/storage/*`': {
159-
ratchet: '#4117 — terminal, same shape as #4088; adapter has no in-repo consumer',
160-
},
161167
};
162168

163169
/** HTTP-verb registrars plus `use`; anything that can claim a path pattern. */

0 commit comments

Comments
 (0)