fix: AppPlugin getService crash on missing i18n/objectql services

ctx.getService() throws when a service is not registered, but
AppPlugin.start() and loadTranslations() assumed it returned undefined.
This caused plugin.app.com.example.crm to crash during startup when
the i18n service was not registered in the dev workspace.

Wrap both getService('objectql') and getService('i18n') calls in
try/catch blocks while preserving the existing null-check fallback
for backward compatibility with mocked contexts.

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>

Author: Copilot

CHANGELOG.md

@@ -8,6 +8,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ## [Unreleased]
 
 ### Fixed
+- **AppPlugin getService crash on missing services** — `AppPlugin.start()` and
+  `loadTranslations()` now wrap `ctx.getService()` in try/catch, since the kernel's
+  `getService` throws when a service is not registered (rather than returning `undefined`).
+  This was the direct cause of `plugin.app.com.example.crm failed to start` — the i18n
+  service was not registered, so `getService('i18n')` threw an unhandled exception.
 - **CLI serve: host config AppPlugin mis-wrap** — `serve.ts` no longer wraps a host/aggregator config
   (one that already contains instantiated plugins in its `plugins` array) with an extra `AppPlugin`.
   This prevents the `plugin.app.dev-workspace failed to start` error and eliminates duplicate plugin

packages/runtime/src/app-plugin.test.ts

@@ -100,6 +100,22 @@ describe('AppPlugin', () => {
         );
     });
 
+    it('start should handle getService throwing for objectql', async () => {
+        const bundle = { id: 'com.test.throw' };
+        const plugin = new AppPlugin(bundle);
+        
+        vi.mocked(mockContext.getService).mockImplementation(() => {
+            throw new Error("[Kernel] Service 'objectql' not found");
+        });
+        
+        await plugin.start!(mockContext);
+        
+        expect(mockContext.logger.warn).toHaveBeenCalledWith(
+            expect.stringContaining('ObjectQL engine service not found'), 
+            expect.any(Object)
+        );
+    });
+
     // ═══════════════════════════════════════════════════════════════
     // i18n translation auto-loading
     // ═══════════════════════════════════════════════════════════════
@@ -173,6 +189,26 @@ describe('AppPlugin', () => {
             );
         });
 
+        it('should skip translation loading when getService throws for i18n', async () => {
+            vi.mocked(mockContext.getService).mockImplementation((name: string) => {
+                if (name === 'objectql') return mockQL;
+                throw new Error("[Kernel] Service 'i18n' not found");
+            });
+
+            const bundle = {
+                id: 'com.test.i18nthrow',
+                translations: [{ en: { messages: { hello: 'Hello' } } }],
+            };
+            const plugin = new AppPlugin(bundle);
+            await plugin.start!(mockContext);
+
+            // Should log debug but not throw
+            expect(mockContext.logger.debug).toHaveBeenCalledWith(
+                expect.stringContaining('No i18n service registered'),
+                expect.any(Object)
+            );
+        });
+
         it('should handle bundle with no translations gracefully', async () => {
             const bundle = { id: 'com.test.notrans' };
             const plugin = new AppPlugin(bundle);

packages/runtime/src/app-plugin.ts

@@ -60,9 +60,15 @@ export class AppPlugin implements Plugin {
 
         // Execute Runtime Step
         // Retrieve ObjectQL engine from services
-        // We cast to any/ObjectQL because ctx.getService returns unknown
-        const ql = ctx.getService('objectql') as any;
-        
+        // ctx.getService throws when a service is not registered, so we
+        // must use try/catch instead of a null-check.
+        let ql: any;
+        try {
+            ql = ctx.getService('objectql');
+        } catch {
+            // Service not registered — handled below
+        }
+
         if (!ql) {
             ctx.logger.warn('ObjectQL engine service not found', { 
                 appName: this.name,
@@ -201,7 +207,15 @@ export class AppPlugin implements Plugin {
      * this keeps AppPlugin resilient across server/dev/mock environments.
      */
     private loadTranslations(ctx: PluginContext, appId: string): void {
-        const i18nService = ctx.getService('i18n') as II18nService | undefined;
+        // ctx.getService throws when a service is not registered, so we
+        // must use try/catch to gracefully skip when no i18n plugin is loaded.
+        let i18nService: II18nService | undefined;
+        try {
+            i18nService = ctx.getService('i18n') as II18nService;
+        } catch {
+            // Service not registered — handled below
+        }
+
         if (!i18nService) {
             ctx.logger.debug('[i18n] No i18n service registered; skipping translation loading', { appId });
             return;