Skip to content

Commit 26e82b3

Browse files
os-zhuangclaude
andauthored
docs(approvals): drop the duplicated approver-kind warning, unbreaking the ratchet (#3130)
#3113's lifecycle walkthrough re-stated a warning the page already makes better 80 lines up (§3 The approval node: position vs the membership tier, including the `os lint` rule that flags it). The duplicate pushed the reserved-word count (ADR-0090 D3) from 5 to 9, so check-role-word failed on every PR cut from main since — #3121 tripped over it. Removing the duplicate and pointing at the original brings the count back to exactly the baselined 5: **no baseline change needed**. The walkthrough keeps a one-line pointer that names the approver kinds and links to the existing callout, which is what a reader needs at that point anyway. Co-authored-by: Jack Zhuang <277994282+os-zhuang@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
1 parent 4cba5a5 commit 26e82b3

1 file changed

Lines changed: 7 additions & 8 deletions

File tree

content/docs/automation/approvals.mdx

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -132,12 +132,10 @@ and the flow run parks until a decision arrives.
132132
Only `approvers` is required on the node; everything else has a default
133133
(`behavior: 'first_response'`, `lockRecord: true`, `maxRevisions: 3`).
134134

135-
<Callout type="warn">
136-
**`type: 'role'` is not a position.** In an approver entry, `role` means the
137-
better-auth membership tier (`owner` / `admin` / `member`). Naming a business
138-
role like `sales_manager` there matches nobody and the request silently has no
139-
approvers — use `{ type: 'position', value: 'sales_manager' }`.
140-
</Callout>
135+
Approver entries resolve by kind — `position`, `user`, `field`, `manager`,
136+
`team`, `department`, `queue`, and the membership-tier kind described in the
137+
[callout above](#3-the-approval-node), which is the one that silently resolves
138+
to nobody when it's mistaken for a business hierarchy.
141139

142140
### The approver finds it in their queue
143141

@@ -150,8 +148,9 @@ curl -b cookies.txt \
150148
"https://your-app.example.com/api/v1/approvals/requests?status=pending&approverId=usr_123"
151149
```
152150

153-
`approverId` accepts a user id, an email, or `role:<r>` — and takes several
154-
values (comma-separated or repeated) to cover a person's identities in one call.
151+
`approverId` accepts a user id, an email, or a membership-tier reference — and
152+
takes several values (comma-separated or repeated) to cover a person's
153+
identities in one call.
155154
Other filters: `status`, `object`, `recordId`, `submitterId`, `q`, `limit`,
156155
`offset`.
157156

0 commit comments

Comments
 (0)