Commit 2819c4b
committed
docs(rest): correct the packages envelope suite's stale note on the code vocabulary (#3843 follow-up)
Two sentences in this suite's header comment were written while #3841 was still
undecided, and #3843 landed after ADR-0112 settled it. Both were left inaccurate:
- "why #3841 still owns the vocabulary" — it does not; ADR-0112 (#3988) closed it
and `ApiErrorSchema.code` is a closed union now.
- "this module needed MINTED codes" — half true. It had nothing to carry over
(its `error` strings were human messages), but only four of the codes here are
registered; the three generic conditions reuse the standard catalog, which is
what the ledger asks for and is the more useful thing to record.
Rewritten to state the actual split and why it makes the assertions below load-
bearing: an unregistered code fails parse, so `BaseResponseSchema.safeParse` is
what would catch an invented one.
Comment-only — no behaviour change. `package-routes.ts` already carried the
corrected note; this is the test file that was missed alongside it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CYbS3kS8xzsHNXFTzp4e2z1 parent d1c8298 commit 2819c4b
1 file changed
Lines changed: 12 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
23 | 31 | | |
24 | 32 | | |
25 | 33 | | |
| |||
0 commit comments