Skip to content

Commit 30c12d1

Browse files
Copilothotlong
andcommitted
Fix code review feedback - correct field dependency direction and enhance rating field documentation
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
1 parent 8b24e2a commit 30c12d1

2 files changed

Lines changed: 9 additions & 9 deletions

File tree

examples/ui-showcase/src/objects/lead.object.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ export const Lead = ObjectSchema.create({
7878

7979
rating: Field.rating(5, {
8080
label: 'Lead Score',
81-
description: 'Lead quality score (1-5 stars)',
81+
description: 'Lead quality score (1-5 stars). Half ratings supported (e.g., 4.5) for granular scoring.',
8282
allowHalf: true,
8383
}),
8484

examples/ui-showcase/src/views/lead.view.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -423,12 +423,12 @@ export const LeadViews = defineView({
423423
fields: [
424424
{ field: 'street', colSpan: 2 },
425425
'city',
426-
'state',
427-
'postal_code',
428426
{
429-
field: 'country',
430-
dependsOn: 'state', // Cascade: country determines available states
427+
field: 'state',
428+
dependsOn: 'country', // Cascade: country determines available states
431429
},
430+
'postal_code',
431+
'country',
432432
],
433433
},
434434
{
@@ -672,12 +672,12 @@ export const LeadViews = defineView({
672672
fields: [
673673
{ field: 'street', colSpan: 2 },
674674
'city',
675-
'state',
676-
'postal_code',
677675
{
678-
field: 'country',
679-
dependsOn: 'state', // Country determines state options
676+
field: 'state',
677+
dependsOn: 'country', // Country determines state options
680678
},
679+
'postal_code',
680+
'country',
681681
],
682682
},
683683
{

0 commit comments

Comments
 (0)