feat(approvals): surface decisionOutputs keys on the request row (#3447 P2 UI enablement)

The decision UI renders one input per author-declared output key; the set
varies per request (each node declares its own), so it rides the request
read (decision_outputs) rather than the object's static action params —
the params array cannot enumerate a per-request field set.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Author: os-zhuang

.changeset/decision-outputs-surface-3447.md

@@ -0,0 +1,6 @@
+---
+"@objectstack/spec": patch
+"@objectstack/plugin-approvals": patch
+---
+
+Surface the approval node's author-declared `decisionOutputs` keys on the request read as `ApprovalRequestRow.decision_outputs` (#3447 P2 UI enablement). The set varies per request (each node declares its own), so it rides the row rather than the object's static action params — a decision UI renders one input per key and POSTs `outputs` with the decision.

packages/plugins/plugin-approvals/src/approval-service.test.ts

@@ -441,6 +441,21 @@ describe('ApprovalService (node era)', () => {
     }, SYS)).rejects.toThrow(/VALIDATION_FAILED.*reserved/s);
   });
 
+  it('decision outputs: declared keys surface on the request row as decision_outputs (#3447 P2 UI)', async () => {
+    // The decision UI renders one input per declared key — the keys ride the
+    // request read (per-request; the static action params can't carry them).
+    const req = await svc.openNodeRequest(
+      openInput(['u9'], {}, { decisionOutputs: ['next_reviewers', 'note'] }), CTX,
+    ) as any;
+    expect(req.decision_outputs).toEqual(['next_reviewers', 'note']);
+    const listed = await svc.listRequests({ status: 'pending' }, SYS);
+    expect((listed[0] as any).decision_outputs).toEqual(['next_reviewers', 'note']);
+    // A node declaring none omits the field entirely.
+    engine._tables['sys_approval_request'] = [];
+    const plain = await svc.openNodeRequest(openInput(['u9']), CTX) as any;
+    expect(plain.decision_outputs).toBeUndefined();
+  });
+
   it('decision outputs: accepted keys return from decideNode and snapshot as __decisionOutputs', async () => {
     const req = await svc.openNodeRequest(
       openInput(['u9'], {}, { decisionOutputs: ['next_reviewers', 'note'] }), CTX,

packages/plugins/plugin-approvals/src/approval-service.ts

@@ -229,6 +229,13 @@ function rowFromRequest(row: any): ApprovalRequestRow {
     sla_due_at: slaDueAt(row.created_at, cfg),
     // ADR-0044 revision round (rides the config snapshot; absent ⇒ round 1).
     round: typeof cfg?.__round === 'number' ? cfg.__round : undefined,
+    // #3447 P2: the node's author-declared decision-output keys, surfaced so a
+    // decision UI can render input fields for them and POST `outputs` on
+    // approve/reject. Per-request (each node declares its own), which is why
+    // this rides the row instead of the static action params.
+    decision_outputs: Array.isArray(cfg?.decisionOutputs) && cfg.decisionOutputs.length
+      ? cfg.decisionOutputs.map(String)
+      : undefined,
   } as any;
 }
 

packages/spec/src/contracts/approval-service.ts

@@ -48,6 +48,13 @@ export interface ApprovalRequestRow {
   /** ADR-0019 correlation: the suspended flow run this request belongs to. */
   flow_run_id?: string;
   flow_node_id?: string;
+  /**
+   * #3447 P2: the node's author-declared decision-output keys
+   * (`config.decisionOutputs`), surfaced from the config snapshot so a
+   * decision UI can render one input per key and POST `outputs` with the
+   * decision. Absent when the node declares none.
+   */
+  decision_outputs?: string[];
   completed_at?: string;
   created_at?: string;
   updated_at?: string;