Skip to content

Commit 3cda8c7

Browse files
hotlongclaude
andcommitted
ci(showcase): build the showcase dependency closure before the smoke
The smoke's webServer (`os serve --dev`) loads the showcase config + its workspace runtime deps (connector-rest, …) from their built dist/. The first run failed with "Cannot find module @objectstack/connector-rest/dist/index.mjs" because only the CLI was built. Build the full dependency closure (`--filter=@objectstack/example-showcase^...`) and bump the timeout to 30m. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1 parent 2e97ff4 commit 3cda8c7

1 file changed

Lines changed: 6 additions & 3 deletions

File tree

.github/workflows/showcase-smoke.yml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
smoke:
1717
name: Showcase nav-surface smoke
1818
runs-on: ubuntu-latest
19-
timeout-minutes: 25
19+
timeout-minutes: 30
2020
steps:
2121
- uses: actions/checkout@v4
2222
- uses: pnpm/action-setup@v4
@@ -25,8 +25,11 @@ jobs:
2525
node-version: 22
2626
cache: pnpm
2727
- run: pnpm install --frozen-lockfile
28-
# The smoke's webServer runs the CLI (`os serve --dev`); build it first.
29-
- run: pnpm turbo run build --filter=@objectstack/cli
28+
# The smoke's webServer runs `os serve --dev`, which loads the showcase
29+
# config + its workspace runtime deps (CLI, connector-rest, …) from their
30+
# built `dist/`. Build the whole dependency closure (excluding the
31+
# showcase's own app build, which serve --dev doesn't need).
32+
- run: pnpm turbo run build --filter=@objectstack/example-showcase^...
3033
- name: Install Playwright Chromium
3134
working-directory: examples/app-showcase
3235
run: pnpm exec playwright install --with-deps chromium

0 commit comments

Comments
 (0)