fix(examples): the showcase authors wait through the declared block (#4045)

Corrects a factual claim in the previous commit. It said "Nothing in-repo authors
it" of the loose `config` back door — that is wrong. The showcase's own
`wait_revision` node authored exactly that shape:

    config: { eventType: 'signal', signalName: 'budget_revision' }

so the back door was not hypothetical, and the example that demonstrates `wait`
was itself on the spelling this PR retires. It moves to `waitEventConfig`.

The conversion already handled this shape correctly — the executor's behaviour is
identical either way, and a new test pins the exact combination the showcase hit:
the DECLARED key names sitting in the UNDECLARED location, which is what the
candidate ordering has to get right (`signalName` before `signal`). It also asserts
the converted flow still parses, since the lift creates the required block.

Found while checking whether a stuck `objectstack verify` CI step could be caused
by this change rather than by the runner — it could not, but the audit that ruled
it out is what surfaced the false claim.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QoA8AV99Ss1RRkLLAYmDzq

Author: claude

.changeset/wait-loose-config-graduation.md

@@ -14,7 +14,9 @@ The executor nevertheless also read six loose `config` keys behind `wec.X ?? loo
 two of them (`duration`, `signal`) spellings the spec never declared anywhere. That is
 the `notify.source` shape #4050 retired: a second de-facto contract announced only by a
 code comment, so an author who wrote it got a flow that worked forever and was never
-steered to the declared spelling (PD #12).
+steered to the declared spelling (PD #12). Not hypothetical: the showcase's own
+`wait_revision` node authored it (`config: { eventType: 'signal', signalName: … }`) and
+moves to the declared block here.
 
 - New ADR-0087 D2 conversion `flow-node-wait-event-config-lift` lifts
   `config.{eventType,timerDuration,duration,timeoutMs,signalName,signal}` onto the

examples/app-showcase/src/automation/flows/index.ts

@@ -206,7 +206,10 @@ export const BudgetApprovalFlow = defineFlow({
       id: 'wait_revision',
       type: 'wait',
       label: 'Awaiting Revision',
-      config: { eventType: 'signal', signalName: 'budget_revision' },
+      // `waitEventConfig`, not a loose `config` — the latter is the undeclared
+      // back door retired in #4045. The conversion layer still rewrites it at
+      // load, but the showcase should demonstrate the declared spelling.
+      waitEventConfig: { eventType: 'signal', signalName: 'budget_revision' },
     },
     {
       id: 'needs_exec',

packages/spec/src/conversions/conversions.test.ts

@@ -291,6 +291,24 @@ describe('conversion layer (ADR-0087 D2)', () => {
       expect(waitNodeOf(stack).config).toEqual({ duration: 'PT2H' });
     });
 
+    /**
+     * The exact shape the showcase's `wait_revision` node carried before this
+     * change — the declared spelling sitting in the undeclared LOCATION, which is
+     * the combination the ledger's candidate order has to get right.
+     */
+    it('lifts the showcase shape: declared key names in a loose `config`', () => {
+      const { stack, notices } = collectConversionNotices(
+        waitFlow({ config: { eventType: 'signal', signalName: 'budget_revision' } }),
+      );
+      expect(waitNodeOf(stack).waitEventConfig).toEqual({
+        eventType: 'signal',
+        signalName: 'budget_revision',
+      });
+      expect(waitNodeOf(stack).config).toEqual({});
+      expect(notices).toHaveLength(2);
+      expect(() => FlowSchema.parse((stack.flows as any[])[0])).not.toThrow();
+    });
+
     it('leaves a wait node with nothing to lift completely untouched', () => {
       const before = waitFlow({ waitEventConfig: { eventType: 'manual' }, config: { note: 'keep me' } });
       const { stack, notices } = collectConversionNotices(structuredClone(before));

packages/spec/src/conversions/registry.ts

@@ -1117,7 +1117,12 @@ const WAIT_EVENT_CONFIG_LIFTS: ReadonlyArray<readonly [target: string, candidate
  * The executor nevertheless carried `wec.X ?? loose.X` for six `config` keys —
  * a second, undeclared de-facto contract of exactly the `notify.source` shape
  * (PD #12), announced only by the comment "for hand-authored flows that put the
- * same keys under config". Nothing in-repo authors it.
+ * same keys under config".
+ *
+ * The showcase's `wait_revision` node authored exactly that shape
+ * (`config: { eventType: 'signal', signalName: 'budget_revision' }`) until this
+ * change moved it to the declared block — so the back door was not hypothetical,
+ * and the example that demonstrates `wait` was itself on the retiring spelling.
  *
  * Precedence mirrors those `??` chains, so the rewrite is behaviour-preserving:
  * a value already on `waitEventConfig` WINS and its loose counterpart is left