Skip to content

Commit 4a58f0a

Browse files
committed
feat: 更新方法参数以提高代码可读性,使用下划线前缀表示未使用的参数
1 parent dfa9c25 commit 4a58f0a

1 file changed

Lines changed: 9 additions & 8 deletions

File tree

packages/objectql/src/protocol.ts

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,7 @@ import type {
44
BatchUpdateRequest,
55
BatchUpdateResponse,
66
UpdateManyDataRequest,
7-
DeleteManyDataRequest,
8-
BatchOperationResult
7+
DeleteManyDataRequest
98
} from '@objectstack/spec/api';
109
import type { MetadataCacheRequest, MetadataCacheResponse } from '@objectstack/spec/api';
1110
import type {
@@ -42,7 +41,7 @@ export class ObjectStackProtocolImplementation implements ObjectStackProtocol {
4241
this.engine = engine;
4342
}
4443

45-
async getDiscovery(request: {}) {
44+
async getDiscovery(_request: {}) {
4645
return {
4746
version: '1.0',
4847
apiName: 'ObjectStack API',
@@ -51,7 +50,7 @@ export class ObjectStackProtocolImplementation implements ObjectStackProtocol {
5150
};
5251
}
5352

54-
async getMetaTypes(request: {}) {
53+
async getMetaTypes(_request: {}) {
5554
return {
5655
types: SchemaRegistry.getRegisteredTypes()
5756
};
@@ -219,7 +218,7 @@ export class ObjectStackProtocolImplementation implements ObjectStackProtocol {
219218
// Batch Operations
220219
// ==========================================
221220

222-
async batchData(request: { object: string, request: BatchUpdateRequest }): Promise<BatchUpdateResponse> {
221+
async batchData(_request: { object: string, request: BatchUpdateRequest }): Promise<BatchUpdateResponse> {
223222
// Map high-level batch request to DataEngine batch if available
224223
// Or implement loop here.
225224
// For now, let's just fail or implement basic loop to satisfying interface
@@ -236,7 +235,7 @@ export class ObjectStackProtocolImplementation implements ObjectStackProtocol {
236235
};
237236
}
238237

239-
async updateManyData(request: UpdateManyDataRequest): Promise<any> {
238+
async updateManyData(_request: UpdateManyDataRequest): Promise<any> {
240239
// TODO: Implement proper updateMany in DataEngine
241240
throw new Error('updateManyData not implemented');
242241
}
@@ -255,14 +254,15 @@ export class ObjectStackProtocolImplementation implements ObjectStackProtocol {
255254

256255
async createView(request: CreateViewRequest): Promise<ViewResponse> {
257256
const id = Math.random().toString(36).substring(7);
257+
// Cast to unknown then SavedView to bypass strict type checks for the mock
258258
const view: SavedView = {
259259
id,
260260
...request,
261261
createdAt: new Date().toISOString(),
262262
updatedAt: new Date().toISOString(),
263263
createdBy: 'system',
264264
updatedBy: 'system'
265-
} as SavedView;
265+
} as unknown as SavedView;
266266

267267
this.viewStorage.set(id, view);
268268
return { success: true, data: view };
@@ -295,7 +295,8 @@ export class ObjectStackProtocolImplementation implements ObjectStackProtocol {
295295
if (!view) throw new Error(`View ${request.id} not found`);
296296

297297
const { id, ...updates } = request;
298-
const updated = { ...view, ...updates, updatedAt: new Date().toISOString() };
298+
// Cast to unknown then SavedView to bypass strict type checks for the mock
299+
const updated = { ...view, ...updates, updatedAt: new Date().toISOString() } as unknown as SavedView;
299300
this.viewStorage.set(request.id, updated);
300301
return { success: true, data: updated };
301302
}

0 commit comments

Comments
 (0)