feat(settings): add configuration group and update settings routes for better organization

Author: hotlong

packages/platform-objects/src/apps/setup.app.ts

@@ -95,6 +95,23 @@ export const SETUP_APP: App = {
         { id: 'nav_approval_actions', type: 'object', label: 'Action History', objectName: 'sys_approval_action', icon: 'history', requiresObject: 'sys_approval_action' },
       ],
     },
+    {
+      id: 'group_configuration',
+      type: 'group',
+      label: 'Configuration',
+      icon: 'sliders-horizontal',
+      children: [
+        // Metadata-driven settings hub. Each entry maps to a SettingsManifest
+        // namespace exposed by @objectstack/service-settings. URL navigation
+        // is used (not `object`) because settings are stored in a generic
+        // K/V table (`sys_setting`) rather than per-namespace objects, and
+        // the renderer is a dedicated <SettingsView> page in objectui.
+        { id: 'nav_settings_hub', type: 'url', label: 'All Settings', url: '/apps/setup/system/settings', icon: 'settings-2' },
+        { id: 'nav_settings_mail', type: 'url', label: 'Email', url: '/apps/setup/system/settings/mail', icon: 'mail' },
+        { id: 'nav_settings_branding', type: 'url', label: 'Branding', url: '/apps/setup/system/settings/branding', icon: 'palette' },
+        { id: 'nav_settings_feature_flags', type: 'url', label: 'Feature Flags', url: '/apps/setup/system/settings/feature_flags', icon: 'flag' },
+      ],
+    },
     {
       id: 'group_diagnostics',
       type: 'group',

packages/services/service-settings/src/settings-routes.test.ts

@@ -1,7 +1,7 @@
 // Copyright (c) 2025 ObjectStack. Licensed under the Apache-2.0 license.
 
 import { describe, expect, it, vi } from 'vitest';
-import type { IHttpServer, IHttpRequest, IHttpResponse, RouteHandler } from '@objectstack/spec/contracts/http-server';
+import type { IHttpServer, IHttpRequest, IHttpResponse, RouteHandler } from '@objectstack/spec/contracts';
 import { SettingsService } from './settings-service';
 import { registerSettingsRoutes } from './settings-routes';
 import { brandingSettingsManifest } from './manifests/branding.manifest';

packages/services/service-settings/src/settings-routes.ts

@@ -13,7 +13,7 @@
  * `SettingsService`.
  */
 
-import type { IHttpServer, IHttpRequest, IHttpResponse } from '@objectstack/spec/contracts/http-server';
+import type { IHttpServer, IHttpRequest, IHttpResponse, RouteHandler } from '@objectstack/spec/contracts';
 import { SettingsService } from './settings-service.js';
 import {
   SettingsLockedError,
@@ -60,17 +60,17 @@ export function registerSettingsRoutes(
   const base = opts.basePath ?? '/api/settings';
   const ctxOf = opts.contextFromRequest ?? defaultContext;
 
-  http.get(base, async (req, res) => {
+  http.get(base, (async (req, res) => {
     try {
       const ctx = ctxOf(req);
       const manifests = service.listManifests(ctx);
       await res.json({ manifests });
     } catch (err: any) {
       sendError(res, 500, 'INTERNAL', err?.message ?? 'Failed to list manifests');
     }
-  });
+  }) satisfies RouteHandler);
 
-  http.get(`${base}/:namespace`, async (req, res) => {
+  http.get(`${base}/:namespace`, (async (req, res) => {
     const ns = req.params.namespace;
     try {
       const ctx = ctxOf(req);
@@ -83,9 +83,9 @@ export function registerSettingsRoutes(
         sendError(res, 500, 'INTERNAL', err?.message ?? 'Failed to read namespace');
       }
     }
-  });
+  }) satisfies RouteHandler);
 
-  http.put(`${base}/:namespace`, async (req, res) => {
+  http.put(`${base}/:namespace`, (async (req, res) => {
     const ns = req.params.namespace;
     const body = (req.body ?? {}) as Record<string, unknown>;
     try {
@@ -107,9 +107,9 @@ export function registerSettingsRoutes(
         sendError(res, 500, 'INTERNAL', err?.message ?? 'Failed to write namespace');
       }
     }
-  });
+  }) satisfies RouteHandler);
 
-  http.post(`${base}/:namespace/:actionId`, async (req, res) => {
+  http.post(`${base}/:namespace/:actionId`, (async (req, res) => {
     const { namespace, actionId } = req.params;
     try {
       const ctx = ctxOf(req);
@@ -123,5 +123,5 @@ export function registerSettingsRoutes(
         sendError(res, 500, 'INTERNAL', err?.message ?? 'Action failed');
       }
     }
-  });
+  }) satisfies RouteHandler);
 }

packages/services/service-settings/src/settings-service.ts

@@ -331,9 +331,9 @@ export class SettingsService {
       };
       const existing = await this.engine.find(this.objectName, { where, limit: 1 });
       if (existing[0]) {
-        await this.engine.update(this.objectName, { where, data: row });
+        await this.engine.update(this.objectName, { where, data: { ...row } });
       } else {
-        await this.engine.insert(this.objectName, row);
+        await this.engine.insert(this.objectName, { ...row });
       }
       return;
     }

packages/services/service-settings/src/settings-service.types.ts

@@ -23,14 +23,8 @@
  * plugin wires those pieces up.
  */
 
-import type {
-  SettingsManifest,
-  ResolvedSettingValue,
-  SettingsNamespacePayload,
-  SettingsActionResult,
-  SpecifierScope,
-} from '@objectstack/spec/system';
-import { CryptoAdapter, NoopCryptoAdapter } from './crypto-adapter.js';
+import type { SettingsActionResult, SpecifierScope } from '@objectstack/spec/system';
+import { type CryptoAdapter } from './crypto-adapter.js';
 
 /** Caller identity used by the resolver and audit log. */
 export interface SettingsContext {
@@ -110,8 +104,6 @@ export interface SettingsServiceOptions {
   objectName?: string;
 }
 
-const DEFAULT_OBJECT = 'sys_setting';
-
 /**
  * Convert `(namespace, key)` to the env var convention defined in
  * ADR-0007: uppercase, dots → underscores, hyphens → underscores.
@@ -121,23 +113,6 @@ export function envKeyOf(namespace: string, key: string): string {
   return slug;
 }
 
-/** Cast an env string to the type hinted by the manifest default. */
-function coerceEnvValue(raw: string, hint: unknown): unknown {
-  if (typeof hint === 'boolean') return raw === 'true' || raw === '1' || raw === 'yes';
-  if (typeof hint === 'number') {
-    const n = Number(raw);
-    return Number.isFinite(n) ? n : raw;
-  }
-  if (Array.isArray(hint) || (hint && typeof hint === 'object')) {
-    try {
-      return JSON.parse(raw);
-    } catch {
-      return raw;
-    }
-  }
-  return raw;
-}
-
 /** Thrown when a caller tries to write a value pinned by env. */
 export class SettingsLockedError extends Error {
   readonly code = 'SETTINGS_LOCKED' as const;