Skip to content

Commit 5bad4e2

Browse files
Claudehotlong
andauthored
fix: resolve test failures and vitest config issues
- Add missing 'use' method to mock in hono-plugin.test.ts to fix "rawApp.use is not a function" error - Update vitest configs to use index.ts paths and add subpath aliases (@objectstack/spec/api, /contracts, /data, etc.) - Remove unused cleanupSuccess variable in build-schemas.ts - Use RETRY_DELAY_BASE_MS constant consistently for exponential backoff delays Agent-Logs-Url: https://github.com/objectstack-ai/framework/sessions/1d9e019e-bf4c-40a2-9034-f3c8d51a7cc0 Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
1 parent d8a828b commit 5bad4e2

5 files changed

Lines changed: 20 additions & 12 deletions

File tree

packages/plugins/driver-memory/vitest.config.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,11 @@ export default defineConfig({
1010
},
1111
resolve: {
1212
alias: {
13-
'@objectstack/core': path.resolve(__dirname, '../../core/src'),
14-
'@objectstack/spec': path.resolve(__dirname, '../../spec/src'),
13+
'@objectstack/core': path.resolve(__dirname, '../../core/src/index.ts'),
14+
'@objectstack/spec/contracts': path.resolve(__dirname, '../../spec/src/contracts/index.ts'),
15+
'@objectstack/spec/data': path.resolve(__dirname, '../../spec/src/data/index.ts'),
16+
'@objectstack/spec/system': path.resolve(__dirname, '../../spec/src/system/index.ts'),
17+
'@objectstack/spec': path.resolve(__dirname, '../../spec/src/index.ts'),
1518
},
1619
},
1720
});

packages/plugins/plugin-hono-server/src/hono-plugin.test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ vi.mock('./adapter', () => ({
2727
close: vi.fn(),
2828
getRawApp: vi.fn().mockReturnValue({
2929
get: vi.fn(),
30+
use: vi.fn(),
3031
})
3132
};
3233
})

packages/plugins/plugin-hono-server/vitest.config.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,11 @@ export default defineConfig({
1010
},
1111
resolve: {
1212
alias: {
13-
'@objectstack/core': path.resolve(__dirname, '../../core/src'),
14-
'@objectstack/spec': path.resolve(__dirname, '../../spec/src'),
13+
'@objectstack/core': path.resolve(__dirname, '../../core/src/index.ts'),
14+
'@objectstack/spec/api': path.resolve(__dirname, '../../spec/src/api/index.ts'),
15+
'@objectstack/spec/contracts': path.resolve(__dirname, '../../spec/src/contracts/index.ts'),
16+
'@objectstack/spec/system': path.resolve(__dirname, '../../spec/src/system/index.ts'),
17+
'@objectstack/spec': path.resolve(__dirname, '../../spec/src/index.ts'),
1518
},
1619
},
1720
});

packages/services/service-ai/vitest.config.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,11 @@ export default defineConfig({
1010
},
1111
resolve: {
1212
alias: {
13-
'@objectstack/core': path.resolve(__dirname, '../../../core/src'),
14-
'@objectstack/spec': path.resolve(__dirname, '../../../spec/src'),
13+
'@objectstack/core': path.resolve(__dirname, '../../core/src/index.ts'),
14+
'@objectstack/spec/ai': path.resolve(__dirname, '../../spec/src/ai/index.ts'),
15+
'@objectstack/spec/contracts': path.resolve(__dirname, '../../spec/src/contracts/index.ts'),
16+
'@objectstack/spec/data': path.resolve(__dirname, '../../spec/src/data/index.ts'),
17+
'@objectstack/spec': path.resolve(__dirname, '../../spec/src/index.ts'),
1518
},
1619
},
1720
});

packages/spec/scripts/build-schemas.ts

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -83,22 +83,20 @@ if (fs.existsSync(OUT_DIR)) {
8383

8484
// Use a more robust cleanup with multiple retries and longer delays
8585
// to handle filesystem race conditions in CI environments
86-
let cleanupSuccess = false;
8786
for (let attempt = 0; attempt < MAX_RETRIES * 2; attempt++) {
8887
try {
8988
// Try removing with native Node.js rmSync
9089
if (fs.existsSync(OUT_DIR)) {
91-
fs.rmSync(OUT_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 200 });
90+
fs.rmSync(OUT_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: RETRY_DELAY_BASE_MS * 2 });
9291
}
9392

9493
// Verify the directory is actually gone
9594
if (!fs.existsSync(OUT_DIR)) {
96-
cleanupSuccess = true;
9795
break;
9896
}
9997

100-
// If still exists, wait before retrying
101-
sleepSync(100 * (attempt + 1));
98+
// If still exists, wait before retrying with exponential backoff
99+
sleepSync(RETRY_DELAY_BASE_MS * (attempt + 1));
102100
} catch (error) {
103101
// If this is the last attempt, log but continue (we'll try to work with what's there)
104102
if (attempt === (MAX_RETRIES * 2 - 1)) {
@@ -107,7 +105,7 @@ if (fs.existsSync(OUT_DIR)) {
107105
break;
108106
}
109107
// Wait before retry with exponential backoff
110-
sleepSync(100 * (attempt + 1));
108+
sleepSync(RETRY_DELAY_BASE_MS * (attempt + 1));
111109
}
112110
}
113111

0 commit comments

Comments
 (0)