Commit 5c8afed
fix(showcase): translate the object-less action, restoring the i18n ratchet
TypeScript Type Check went red on `check:i18n-coverage`, not on types:
examples/app-showcase/objectstack.config.ts: untranslated declared
strings grew 456 -> 458
That gate freezes each example's untranslated-string debt and fails the
moment it grows. The new action declares exactly two strings — `label` and
`successMessage` — so the +2 is mine.
Translated rather than ratcheted. Raising the baseline to 458 would have
made the gate green by widening the debt it exists to prevent, and there is
in-file precedent against that: `showcase_action_param_gallery`'s
`p_assignee` was "translated at birth" for this exact reason (#3405).
The keys go under the bundle's top-level `globalActions` slot, which is the
ONLY place the resolver looks for an action declaring no `objectName` —
keys for such an action under `objects.*._actions` are never read. That
slot had zero users anywhere in the repo before this, which follows from
the same gap #3913 left: no object-less action existed to translate. So the
specimen now also covers the object-less translation path.
Verified the key genuinely resolves rather than being silently ignored: with
the name misspelled, `os lint` reports `translation-target-unknown` at
`translations[0].en.globalActions.showcase_portfolio_snapshotX` with a "Did
you mean showcase_portfolio_snapshot?" suggestion; spelled correctly it is
clean.
check-i18n-coverage back to OK (none new, baseline untouched at 456),
`os lint` 0 errors, tsc clean, eslint clean, 60 tests pass, build green.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011AvZj6cLX7APd7roh2eK4F1 parent a33c76e commit 5c8afed
1 file changed
Lines changed: 22 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
138 | 138 | | |
139 | 139 | | |
140 | 140 | | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
141 | 152 | | |
142 | 153 | | |
143 | 154 | | |
| |||
286 | 297 | | |
287 | 298 | | |
288 | 299 | | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
289 | 311 | | |
290 | 312 | | |
0 commit comments