Skip to content

Commit 631deba

Browse files
os-zhuangclaude
andauthored
ci: drop the OS_SANDBOX_HOOK_TIMEOUT_MS=10000 floor — redundant after ADR-0102 D1 (#3328)
#3270 raised the sandbox hook budget workflow-wide to paper over the #3259 load flake: on an oversubscribed runner the fixed per-invocation WASM-creation cost alone tripped the 250ms *wall-clock* hook deadline. ADR-0102 D1 (#3301) changed the budget to *script CPU-time* — VM creation and idle host-await time are no longer charged — so the 250ms default is meaningful again on a loaded runner and this global floor is no longer needed. Removing it also validates the fix end-to-end: the sandbox suite (incl. the nested-write integration tests, which run at the stock default) must stay green at 250ms on CI. Tests that assert a specific budget set it explicitly and are unaffected; production always kept 250ms/5000ms. The env override remains available for constrained hardware. Claude-Session: https://claude.ai/code/session_011iJLjqToxNv1aYP3syQtRp Co-authored-by: Claude <noreply@anthropic.com>
1 parent e412fb6 commit 631deba

1 file changed

Lines changed: 0 additions & 11 deletions

File tree

.github/workflows/ci.yml

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -15,17 +15,6 @@ concurrency:
1515
group: ci-${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
1616
cancel-in-progress: true
1717

18-
# The QuickJS sandbox compiles a fresh WASM module per hook/action invocation
19-
# (and a nested hook compiles another inside the parent's budget). Hosted runners
20-
# are 4-vCPU and the test job oversubscribes them (`turbo --concurrency=4` + each
21-
# vitest worker), so that fixed VM-creation cost alone intermittently tripped the
22-
# 250ms hook default even while the VM was progressing — a load flake unrelated to
23-
# the change under test (#3259). Raise the sandbox hook budget for the whole
24-
# workflow; production keeps the 250ms default (this only sets it in CI). Real
25-
# hangs are still bounded by each test's own vitest timeout.
26-
env:
27-
OS_SANDBOX_HOOK_TIMEOUT_MS: '10000'
28-
2918
jobs:
3019
filter:
3120
runs-on: ubuntu-latest

0 commit comments

Comments
 (0)