feat(spec)!: remove deprecated IUIService contract — use IMetadataService (11.0) (#2374)

Author: os-zhuang

.changeset/v11-remove-iuiservice.md

@@ -0,0 +1,17 @@
+---
+"@objectstack/spec": major
+"@objectstack/plugin-dev": major
+---
+
+Remove the deprecated `IUIService` contract (use `IMetadataService`) — 11.0.
+
+`IUIService` (spec `contracts/ui-service.ts`) was superseded by `IMetadataService`
+(views/dashboards are metadata: `metadata.get('view', …)` / `register(…)`). This
+removes the dead interface and its dev stub:
+
+- spec: delete `contracts/ui-service.ts` + its barrel export.
+- plugin-dev: drop the bespoke `ui` dev stub (`createUIStub`). `'ui'` remains a
+  `CoreServiceName`, so dev mode still registers a generic stub for it via the
+  fallback path; only the obsolete view/dashboard methods are gone.
+
+Use `IMetadataService` for view/dashboard CRUD.

packages/plugins/plugin-dev/src/dev-plugin.test.ts

@@ -176,13 +176,6 @@ describe('DevPlugin', () => {
     expect(i18n.t('missing', 'en')).toBe('missing');
     expect(Array.isArray(i18n.getLocales())).toBe(true);
 
-    // ── Verify IUIService contract ──
-    const ui = registeredServices.get('ui');
-    ui.registerView('test_view', { name: 'test_view', object: 'account' });
-    expect(ui.getView('test_view')).toBeDefined();
-    expect(Array.isArray(ui.listViews())).toBe(true);
-    expect(ui.listViews('account')).toHaveLength(1);
-
     // ── Verify IWorkflowService contract ──
     const workflow = registeredServices.get('workflow');
     const transResult = await workflow.transition({ recordId: 'r1', object: 'order', targetState: 'approved' });

packages/plugins/plugin-dev/src/dev-plugin.ts

@@ -160,25 +160,6 @@ function createI18nStub() {
   };
 }
 
-/** IUIService — delegates to IMetadataService when available, falls back to in-memory Map */
-function createUIStub() {
-  const views = new Map<string, any>();
-  const dashboards = new Map<string, any>();
-  return {
-    _dev: true, _serviceName: 'ui',
-    _deprecated: 'Use IMetadataService instead. This stub will be removed in v4.0.0.',
-    getView(name: string) { return views.get(name); },
-    listViews(object?: string) {
-      const all = [...views.values()];
-      return object ? all.filter(v => v.object === object) : all;
-    },
-    getDashboard(name: string) { return dashboards.get(name); },
-    listDashboards() { return [...dashboards.values()]; },
-    registerView(name: string, definition: unknown) { views.set(name, definition); },
-    registerDashboard(name: string, definition: unknown) { dashboards.set(name, definition); },
-  };
-}
-
 /** IWorkflowService — in-memory workflow state stub */
 function createWorkflowStub() {
   const states = new Map<string, string>(); // recordKey → currentState
@@ -299,7 +280,6 @@ const DEV_STUB_FACTORIES: Record<string, () => Record<string, any>> = {
   'notification': createNotificationStub,
   'ai':          createAIStub,
   'i18n':        createI18nStub,
-  'ui':          createUIStub,
   'workflow':    createWorkflowStub,
   'metadata':    createMetadataStub,
   'data':        createDataStub,

packages/spec/api-surface.json

@@ -3498,7 +3498,6 @@
     "ITeamGraphService (interface)",
     "ITenantRouter (interface)",
     "ITypedEventEmitter (interface)",
-    "IUIService (interface)",
     "IWorkflowService (interface)",
     "ImportObjectOpts (interface)",
     "ImportObjectResult (interface)",

packages/spec/src/contracts/index.ts

@@ -31,7 +31,6 @@ export * from './job-service.js';
 export * from './ai-service.js';
 export * from './llm-adapter.js';
 export * from './i18n-service.js';
-export * from './ui-service.js';
 export * from './workflow-service.js';
 export * from './feed-service.js';
 export * from './export-service.js';