Commit 672bf14
committed
fix(spec,objectql): changeset is a MAJOR bump, and sweep the last findStream stub
Two defects found reviewing the retirement against the `spec-property-retirement`
checklist:
- The changeset declared `minor` for all four packages. Removing a REQUIRED
method from a published contract interface is breaking — the skill says
`major` for `@objectstack/spec`, and it is the house convention for every
other `!` spec change in this major (`session-dual-source-c4`,
`notification-dual-source-c3`). The driver packages drop a public method too,
so they go major with it.
- `protocol-batch-atomic.test.ts` still carried a `findStream() { throw new
Error('not implemented'); }` stub. It is typed `any`, so it compiles and is
simply dead — but it is exactly the stub this issue exists to sweep, and
leaving one behind lets the next reader infer the method still exists.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012C2cd7tL8QDoZ2QKN3djJ51 parent 92200cb commit 672bf14
2 files changed
Lines changed: 4 additions & 5 deletions
File tree
- .changeset
- packages/objectql/src
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
3 | | - | |
4 | | - | |
5 | | - | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
52 | | - | |
53 | 52 | | |
54 | 53 | | |
55 | 54 | | |
| |||
0 commit comments