Skip to content

Commit 672bf14

Browse files
committed
fix(spec,objectql): changeset is a MAJOR bump, and sweep the last findStream stub
Two defects found reviewing the retirement against the `spec-property-retirement` checklist: - The changeset declared `minor` for all four packages. Removing a REQUIRED method from a published contract interface is breaking — the skill says `major` for `@objectstack/spec`, and it is the house convention for every other `!` spec change in this major (`session-dual-source-c4`, `notification-dual-source-c3`). The driver packages drop a public method too, so they go major with it. - `protocol-batch-atomic.test.ts` still carried a `findStream() { throw new Error('not implemented'); }` stub. It is typed `any`, so it compiles and is simply dead — but it is exactly the stub this issue exists to sweep, and leaving one behind lets the next reader infer the method still exists. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012C2cd7tL8QDoZ2QKN3djJ5
1 parent 92200cb commit 672bf14

2 files changed

Lines changed: 4 additions & 5 deletions

File tree

.changeset/data-driver-find-stream-retired.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
---
2-
"@objectstack/spec": minor
3-
"@objectstack/driver-sql": minor
4-
"@objectstack/driver-memory": minor
5-
"@objectstack/driver-mongodb": minor
2+
"@objectstack/spec": major
3+
"@objectstack/driver-sql": major
4+
"@objectstack/driver-memory": major
5+
"@objectstack/driver-mongodb": major
66
---
77

88
refactor(spec,drivers)!: retire `IDataDriver.findStream` — a required method with no caller, whose two main implementations did the opposite of what it promised (#4484, ADR-0049 enforce-or-remove)

packages/objectql/src/protocol-batch-atomic.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ function makeSnapshotDriver() {
4949
async checkHealth() { return true; },
5050
async execute() { return null; },
5151
async find(object: string) { return Array.from(storeFor(object).values()); },
52-
findStream() { throw new Error('not implemented'); },
5352
async findOne(object: string, ast: any, options: any) {
5453
seen.findOne.push({ object, transaction: options?.transaction });
5554
const id = ast?.where?.id ?? ast?.filters?.id;

0 commit comments

Comments
 (0)