Commit 67bf2e2
`DashboardWidgetSchema` has been strict since the ADR-0021 cutover, and its
error map states the reason in its own words: undeclared keys "were dropped
silently before strict validation, shipping inert metadata". Everything AROUND
the widget kept the posture the widget was rescued from — the header, its
actions, the global filters and their option sources, the date range, and the
dashboard root.
Three keys get a prescription rather than a rename, because a rename would be
wrong:
- `layout` on the dashboard reads like a template selector; there is none.
Layout is per-widget, and a widget without one is auto-flowed.
- `subtitle` on the header: the header renders the dashboard's own
label/description, with only showTitle/showDescription to toggle them.
- `filterBindings` on a filter: the binding runs the other way — a WIDGET
maps this filter's name to one of its own fields, or false to opt out.
Deliberately left open. `DashboardWidgetOptionsSchema` stays passthrough: it is
the renderer-extras escape hatch by design, and the four keys in it that do
reach the analytics query are already declared explicitly (framework#3588).
Closing it would break the escape hatch to fix a problem already fixed the right
way. The widget's bespoke error map also stays — it works and is tested;
converging it onto strictObject is a follow-up, not a prerequisite.
Registered types closed: 23 of 25. Still open: action, view — the last two, so
the warning layer is down to two covered roots. When both close it has nothing
left to warn about at a root, which is the campaign finishing rather than the
layer breaking; the test says so in place rather than being deleted.
Surfaced while re-pointing a test at `view`: one unknown key on a view reports
TWICE, because `view` is a union and the walk emits per strip-mode variant.
Recorded in the test rather than dodged by picking a non-union collection.
Verified: 284 files / 7240 tests, tsc clean, 8 generated artifacts current, all
10 spec gates green, and CRM/Todo/showcase/platform-objects build (showcase
carries three real dashboards).
Claude-Session: https://claude.ai/code/session_01WnqGjQFQMqd5k81LYV8SCY
Co-authored-by: Claude <noreply@anthropic.com>
1 parent 07a4e26 commit 67bf2e2
4 files changed
Lines changed: 123 additions & 20 deletions
File tree
- .changeset
- packages/spec/src
- kernel
- ui
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
Lines changed: 23 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
57 | | - | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
58 | 60 | | |
59 | 61 | | |
60 | 62 | | |
61 | | - | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
62 | 68 | | |
63 | 69 | | |
64 | 70 | | |
| |||
163 | 169 | | |
164 | 170 | | |
165 | 171 | | |
166 | | - | |
167 | | - | |
168 | | - | |
169 | | - | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
170 | 176 | | |
171 | | - | |
172 | | - | |
| 177 | + | |
| 178 | + | |
173 | 179 | | |
174 | 180 | | |
175 | | - | |
| 181 | + | |
176 | 182 | | |
177 | | - | |
178 | | - | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
179 | 190 | | |
| 191 | + | |
180 | 192 | | |
181 | 193 | | |
182 | 194 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
218 | 218 | | |
219 | 219 | | |
220 | 220 | | |
221 | | - | |
| 221 | + | |
222 | 222 | | |
223 | 223 | | |
224 | 224 | | |
| |||
285 | 285 | | |
286 | 286 | | |
287 | 287 | | |
288 | | - | |
| 288 | + | |
289 | 289 | | |
290 | 290 | | |
291 | 291 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| 6 | + | |
6 | 7 | | |
7 | 8 | | |
8 | 9 | | |
| |||
44 | 45 | | |
45 | 46 | | |
46 | 47 | | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
47 | 61 | | |
48 | 62 | | |
49 | 63 | | |
50 | 64 | | |
51 | | - | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
52 | 70 | | |
53 | 71 | | |
54 | 72 | | |
| |||
66 | 84 | | |
67 | 85 | | |
68 | 86 | | |
69 | | - | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
70 | 97 | | |
71 | 98 | | |
72 | 99 | | |
| |||
339 | 366 | | |
340 | 367 | | |
341 | 368 | | |
342 | | - | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
343 | 374 | | |
344 | 375 | | |
345 | 376 | | |
| |||
357 | 388 | | |
358 | 389 | | |
359 | 390 | | |
360 | | - | |
| 391 | + | |
| 392 | + | |
| 393 | + | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
| 397 | + | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
361 | 401 | | |
362 | 402 | | |
363 | 403 | | |
| |||
377 | 417 | | |
378 | 418 | | |
379 | 419 | | |
380 | | - | |
| 420 | + | |
| 421 | + | |
| 422 | + | |
| 423 | + | |
| 424 | + | |
381 | 425 | | |
382 | 426 | | |
383 | 427 | | |
| |||
424 | 468 | | |
425 | 469 | | |
426 | 470 | | |
427 | | - | |
| 471 | + | |
| 472 | + | |
| 473 | + | |
| 474 | + | |
| 475 | + | |
| 476 | + | |
| 477 | + | |
| 478 | + | |
| 479 | + | |
| 480 | + | |
| 481 | + | |
| 482 | + | |
| 483 | + | |
| 484 | + | |
| 485 | + | |
| 486 | + | |
| 487 | + | |
| 488 | + | |
| 489 | + | |
428 | 490 | | |
429 | 491 | | |
430 | 492 | | |
| |||
450 | 512 | | |
451 | 513 | | |
452 | 514 | | |
453 | | - | |
| 515 | + | |
| 516 | + | |
| 517 | + | |
| 518 | + | |
| 519 | + | |
454 | 520 | | |
455 | 521 | | |
456 | 522 | | |
| |||
0 commit comments