Commit 73256b7
committed
docs(runtime): the ordering note in createStandaloneStack describes the order the kernel actually resolves (#4131)
The comment on `defaultDatasourcePlugin`'s slot claimed the position was
load-bearing — "MUST precede ObjectQLPlugin: its start() connects the default
driver … ObjectQLPlugin.start() runs boot schema-sync right after". Both halves
are wrong, and reading the slot as a guarantee is how #4085 happened:
- the connect happens in `init()`, not `start()`;
- the position cannot deliver that order anyway. `DefaultDatasourcePlugin`
declares a hard dependency on ObjectQL, so `resolveDependencies` HOISTS
ObjectQLPlugin ahead of it. Measured on a real serve boot:
`com.objectstack.engine.objectql` inits at #10,
`com.objectstack.runtime.default-datasource` at #16 — the reverse of what the
slot reads as.
What actually orders them is the phase split (Phase 1 completes before any
`start()`) plus that declared dependency — the contract already documented on
the plugin itself, under its "Ordering — phase, not list position" note, which
records the no-tables boot that taught it to us. This comment now points there
instead of contradicting it two files away.
Comment only; no behaviour changes.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ve9HidCGRGtS2UjNPUGHSV1 parent 857a6cf commit 73256b7
2 files changed
Lines changed: 23 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
306 | 306 | | |
307 | 307 | | |
308 | 308 | | |
309 | | - | |
310 | | - | |
311 | | - | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
312 | 327 | | |
313 | 328 | | |
314 | 329 | | |
| |||
0 commit comments