Skip to content

Commit 774f8a2

Browse files
os-zhuangclaude
andauthored
docs(create-objectstack): correct a bogus issue reference in the pnpm-build-approvals comments (#3125)
#3119 cited "#3110" in four comments as the pnpm 11 build-approvals bug. #3110 is an unrelated, already-closed issue — "ObjectLogger file destination silently no-ops in ESM builds" (fixed by #3116). The reference was fabricated: the pnpm 11 scaffold breakage was found while diagnosing the red Publish Smoke gate and has no issue of its own, so the correct citation is the PR that fixed it, #3119. Comment-only. It left a wrong pointer in the two places most likely to be read next: the "why is the smoke's pnpm unpinned" rationale in the script header, and the ratchet guarding the template. The template pnpm-workspace.yaml and the changeset never cited it, so nothing user-facing shipped with the bad reference. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1 parent fb107b8 commit 774f8a2

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

packages/create-objectstack/src/template-consistency.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,10 +74,10 @@ describe('blank template manifest engines.protocol (ADR-0087 D1)', () => {
7474

7575
// pnpm 11 turned an unapproved dependency build script from a warning into a
7676
// hard error, so the template declaring nothing meant `npx create-objectstack`
77-
// + `pnpm install` exited 1 for every user on a current pnpm (#3110). Both keys
77+
// + `pnpm install` exited 1 for every user on a current pnpm (#3119). Both keys
7878
// are load-bearing and read by different pnpm versions: pnpm 11 honours only
7979
// `allowBuilds`, while pnpm 10.0–10.30 understand only `onlyBuiltDependencies`.
80-
describe('blank template pnpm build approvals (#3110)', () => {
80+
describe('blank template pnpm build approvals (#3119)', () => {
8181
const wsPath = path.join(pkgRoot, 'src', 'templates', 'blank', 'pnpm-workspace.yaml');
8282
const APPROVED = ['better-sqlite3', 'esbuild'];
8383
// Strip comments: the prose below explains these keys and must not satisfy

scripts/publish-smoke.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
# create-objectstack template needs updating. It has already happened once:
4949
# pnpm 11 turned unapproved build scripts from a warning into a hard error, so
5050
# every `npx create-objectstack` + `pnpm install` exited 1 until the template
51-
# started declaring `allowBuilds` (#3110).
51+
# started declaring `allowBuilds` (#3119).
5252
#
5353
# Usage:
5454
# bash scripts/publish-smoke.sh
@@ -129,7 +129,7 @@ if [ "$SMOKE_MODE" = "pack" ]; then
129129
# Appending, not overwriting, is load-bearing: the template's build-approval
130130
# block (allowBuilds / onlyBuiltDependencies) is part of what a user gets, so
131131
# it has to be part of what this gate tests. This script used to hand-write
132-
# the whole file, declaring the approvals itself — which is exactly how #3110
132+
# the whole file, declaring the approvals itself — which is exactly how #3119
133133
# stayed invisible here: a locally-authored declaration proves nothing about
134134
# what the template ships.
135135
#

0 commit comments

Comments
 (0)