fix: Address code review feedback — JSDoc formatting, PURL encoding, schema detection

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>

Author: Copilot

packages/cli/src/commands/generate.ts

@@ -290,8 +290,9 @@ function generateTypesFromConfig(config: Record<string, unknown>): string {
       const fType = String(fieldDef.type || 'text');
       const tsType = fieldTypeToTs(fType, !!fieldDef.multiple);
       const required = fieldDef.required ? '' : '?';
-      const desc = fieldDef.label ? ` /** ${fieldDef.label} */` : '';
-      lines.push(`${desc}`);
+      if (fieldDef.label) {
+        lines.push(`  /** ${fieldDef.label} */`);
+      }
       lines.push(`  ${fieldName}${required}: ${tsType};`);
     }
 

packages/spec/scripts/build-openapi.ts

@@ -252,9 +252,9 @@ function generateComponentSchemas(): Record<string, Record<string, unknown>> {
   };
 
   for (const [name, schema] of Object.entries(contractSchemas)) {
-    if (schema instanceof z.ZodType) {
+    if (schema && typeof schema === 'object' && '_zod' in schema) {
       try {
-        schemas[name] = z.toJSONSchema(schema, { target: 'draft-2020-12' });
+        schemas[name] = z.toJSONSchema(schema as z.ZodType, { target: 'draft-2020-12' });
       } catch {
         schemas[name] = { type: 'object', description: `${name} (schema too complex for auto-generation)` };
       }

packages/spec/scripts/generate-sbom.ts

@@ -156,7 +156,7 @@ for (const [name, info] of deps) {
     type: 'library',
     name,
     version: info.version,
-    purl: `pkg:npm/${name.replace('/', '%2F')}@${info.version}`,
+    purl: `pkg:npm/${encodeURIComponent(name)}@${info.version}`,
     licenses: license !== 'UNKNOWN' ? [{ license: { id: license } }] : [],
     description: undefined,
   });

packages/spec/src/benchmark.bench.ts

@@ -8,9 +8,10 @@
  */
 
 import { bench, describe } from 'vitest';
+// Benchmark uses `as any` for schema access since schemas use Object.assign
+// patterns that complicate direct typing. This is acceptable for benchmarks.
 import * as Data from './data';
 import * as UI from './ui';
-import * as System from './system';
 import * as Kernel from './kernel';
 import * as API from './api';
 import * as AI from './ai';