Skip to content

Commit 7ba9328

Browse files
os-zhuangclaude
andauthored
fix(spec): regenerate stale api-surface snapshot after dead page-config removal (#2268) (#2272)
#2268 hard-removed 16 dead exports (6 from ./ui Blank/RecordReview, 10 from ./studio PageBuilder/Canvas/Palette) and #2265 added PAGE_TYPE_ROADMAP, but the committed api-surface.json snapshot was never regenerated — so check:api-surface has been red on main for every PR touching packages/spec/** (surfaced on #2269). Regenerate the snapshot to match the built surface. Diff is exactly the 16 intentional removals + PAGE_TYPE_ROADMAP; api-surface-signatures.json unchanged; the frozen downstream-contract gate is unaffected (it never referenced these symbols). Kept at minor (not a major bump) as a deliberate, documented exception to the ADR-0059 §4 freeze contract — see the appended note in the #2268 changeset. The removed symbols are config for renderless page types with no plausible functional consumer; the pre-publish hotcrm live gate guards any real break. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
1 parent 0fc43ba commit 7ba9328

2 files changed

Lines changed: 11 additions & 16 deletions

File tree

.changeset/page-hard-remove-dead-schemas.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,3 +20,13 @@ references (objectui#1949). This deletes the now-unreachable surface:
2020

2121
The `page` liveness ledger drops to 15 properties (the 2 `dead` entries are gone).
2222
No consumers in framework or objectui (objectui#1949 already merged).
23+
24+
**Version note (kept `minor`, not `major`).** These exports shipped in the
25+
published `10.3.0`, so under ADR-0059 §4 (the freeze contract) a removal would
26+
normally demand a major bump. It is kept `minor` as a deliberate, documented
27+
exception: the removed symbols are config schemas for the renderless
28+
`blank`/`record_review` page types — authoring those already failed at runtime
29+
("Unknown component type"), the frozen `@objectstack/downstream-contract`
30+
fixture never referenced them, and the pre-publish hotcrm live gate guards
31+
against any real consumer break. The `api-surface.json` snapshot is regenerated
32+
alongside this so the removal is acknowledged, not silent.

packages/spec/api-surface.json

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -2989,10 +2989,6 @@
29892989
"AppearanceConfigSchema (const)",
29902990
"AriaProps (type)",
29912991
"AriaPropsSchema (const)",
2992-
"BlankPageLayout (type)",
2993-
"BlankPageLayoutItem (type)",
2994-
"BlankPageLayoutItemSchema (const)",
2995-
"BlankPageLayoutSchema (const)",
29962992
"BorderRadius (type)",
29972993
"BorderRadiusSchema (const)",
29982994
"BreakpointColumnMapSchema (const)",
@@ -3171,6 +3167,7 @@
31713167
"OfflineConfigSchema (const)",
31723168
"OfflineStrategy (type)",
31733169
"OfflineStrategySchema (const)",
3170+
"PAGE_TYPE_ROADMAP (const)",
31743171
"Page (type)",
31753172
"PageAccordionProps (const)",
31763173
"PageCardProps (const)",
@@ -3235,8 +3232,6 @@
32353232
"RecordHighlightsProps (const)",
32363233
"RecordPathProps (const)",
32373234
"RecordRelatedListProps (const)",
3238-
"RecordReviewConfig (type)",
3239-
"RecordReviewConfigSchema (const)",
32403235
"Report (type)",
32413236
"ReportChart (type)",
32423237
"ReportChartInput (type)",
@@ -3825,10 +3820,6 @@
38253820
"ActionLocationSchema (const)",
38263821
"ActivationEventSchema (const)",
38273822
"BUILT_IN_NODE_DESCRIPTORS (const)",
3828-
"CanvasSnapSettings (type)",
3829-
"CanvasSnapSettingsSchema (const)",
3830-
"CanvasZoomSettings (type)",
3831-
"CanvasZoomSettingsSchema (const)",
38323823
"CommandContribution (type)",
38333824
"CommandContributionSchema (const)",
38343825
"ERDiagramConfig (type)",
@@ -3837,8 +3828,6 @@
38373828
"ERLayoutAlgorithmSchema (const)",
38383829
"ERNodeDisplay (type)",
38393830
"ERNodeDisplaySchema (const)",
3840-
"ElementPaletteItem (type)",
3841-
"ElementPaletteItemSchema (const)",
38423831
"FieldEditorConfig (type)",
38433832
"FieldEditorConfigSchema (const)",
38443833
"FieldGroup (type)",
@@ -3861,8 +3850,6 @@
38613850
"FlowNodeRenderDescriptorSchema (const)",
38623851
"FlowNodeShape (type)",
38633852
"FlowNodeShapeSchema (const)",
3864-
"InterfaceBuilderConfig (type)",
3865-
"InterfaceBuilderConfigSchema (const)",
38663853
"MetadataIconContribution (type)",
38673854
"MetadataIconContributionSchema (const)",
38683855
"MetadataViewerContribution (type)",
@@ -3883,8 +3870,6 @@
38833870
"ObjectPreviewTabSchema (const)",
38843871
"ObjectSortField (type)",
38853872
"ObjectSortFieldSchema (const)",
3886-
"PageBuilderConfig (type)",
3887-
"PageBuilderConfigSchema (const)",
38883873
"PanelContribution (type)",
38893874
"PanelContributionSchema (const)",
38903875
"PanelLocationSchema (const)",

0 commit comments

Comments
 (0)