feat(spec): mark the deprecated role approver type with xEnumDeprecated (#3133)

Dogfooding the Studio flow designer surfaced the gap the rename alone left:
the approver-type dropdown derives straight from this enum, so adding
`org_membership_level` beside `role` put the NEW name in the list without
removing the trap — `role` was still one click away from `position`.

`.meta({ xEnumDeprecated })` on the approver type (sourced from
DEPRECATED_APPROVER_TYPES, the single map) rides into the published node
configSchema. Renderers omit listed members from pickers while still rendering
a stored value, so a 15.x flow keeps loading. Locked by a test asserting the
published schema carries it (the objectui side reads exactly this key).

No new export (api-surface unchanged); generated references stay in sync.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Author: os-zhuang

packages/spec/src/automation/approval.test.ts

@@ -9,6 +9,7 @@ import {
   ApprovalNodeApproverSchema,
   ApprovalEscalationSchema,
   ApprovalNodeConfigSchema,
+  getApprovalNodeConfigJsonSchema,
 } from './approval.zod';
 
 describe('ApproverType', () => {
@@ -40,6 +41,20 @@ describe('ApproverType', () => {
       expect(() => ApproverType.parse(target)).not.toThrow();
     }
   });
+
+  // Cross-repo contract: the published node configSchema must carry
+  // `xEnumDeprecated` on the approver type, or the Studio designer (objectui)
+  // derives its dropdown straight from `enum` and keeps offering `role` — the
+  // exact trap ADR-0090 D3 retires. Renderers read this to omit deprecated
+  // members from pickers while still rendering a stored value.
+  it('publishes xEnumDeprecated on the approver type so pickers can drop `role`', () => {
+    const schema = getApprovalNodeConfigJsonSchema() as any;
+    const typeNode = schema?.properties?.approvers?.items?.properties?.type;
+    expect(typeNode?.enum).toContain('role');            // still parses (back-compat)
+    expect(typeNode?.enum).toContain('org_membership_level');
+    expect(typeNode?.xEnumDeprecated).toEqual(Object.keys(DEPRECATED_APPROVER_TYPES));
+    expect(typeNode?.xEnumDeprecated).toContain('role');
+  });
 });
 
 describe('Approval node constants (ADR-0019)', () => {

packages/spec/src/automation/approval.zod.ts

@@ -99,7 +99,14 @@ export const APPROVAL_BRANCH_LABELS = {
 
 /** A single approver assignment on an Approval node. */
 export const ApprovalNodeApproverSchema = lazySchema(() => z.object({
-  type: ApproverType,
+  // `xEnumDeprecated` lists enum members that still PARSE but must not be
+  // offered for new authoring. Without it the Studio designer derives its
+  // approver-type dropdown straight from this enum and keeps offering `role`
+  // — the exact trap ADR-0090 D3 is retiring — one click away from `position`.
+  // Renderers omit these from pickers while still rendering a stored value.
+  type: ApproverType.meta({
+    xEnumDeprecated: Object.keys(DEPRECATED_APPROVER_TYPES),
+  }),
   /**
    * The approver reference, interpreted per `type`: a user id (`user`), a
    * membership tier — owner/admin/member (`org_membership_level`), a position