Merge pull request #642 from objectstack-ai/copilot/fix-build-and-test-another-one

Author: hotlong

packages/client-react/src/data-hooks.tsx

@@ -392,7 +392,7 @@ export function usePagination<T = any>(
     skip: (page - 1) * pageSize
   });
 
-  const totalCount = queryResult.data?.count || 0;
+  const totalCount = queryResult.data?.total || 0;
   const totalPages = Math.ceil(totalCount / pageSize);
   const hasNextPage = page < totalPages;
   const hasPreviousPage = page > 1;
@@ -546,7 +546,7 @@ export function useInfiniteQuery<T = any>(
       }
 
       // Determine if there's a next page
-      const fetchedCount = result.value?.length ?? 0;
+      const fetchedCount = result.records?.length ?? 0;
       const hasMore = fetchedCount === pageSize;
       setHasNextPage(hasMore);
 
@@ -580,7 +580,7 @@ export function useInfiniteQuery<T = any>(
     await fetchPage(0);
   }, [fetchPage]);
 
-  const flatData = pages.flatMap(page => page.value ?? []);
+  const flatData = pages.flatMap(page => page.records ?? []);
 
   return {
     data: pages,

packages/client-react/src/metadata-hooks.tsx

@@ -112,7 +112,7 @@ export function useObject(
         onSuccess?.(result.data || data);
       } else {
         // Direct fetch without cache
-        const result = await client.meta.getObject(objectName);
+        const result = await client.meta.getItem('object', objectName);
         setData(result);
         onSuccess?.(result);
       }

packages/metadata/src/metadata-manager.ts

@@ -519,9 +519,9 @@ export class MetadataManager implements IMetadataService {
         data: event.data,
       });
     };
-    this.watch(type, wrappedCallback);
+    this.addWatchCallback(type, wrappedCallback);
     return {
-      unsubscribe: () => this.unwatch(type, wrappedCallback),
+      unsubscribe: () => this.removeWatchCallback(type, wrappedCallback),
     };
   }
 
@@ -623,7 +623,7 @@ export class MetadataManager implements IMetadataService {
    * Validate a metadata item against its type schema.
    * Returns validation result with errors and warnings.
    */
-  async validate(type: string, data: unknown): Promise<MetadataValidationResult> {
+  async validate(_type: string, data: unknown): Promise<MetadataValidationResult> {
     // Basic structural validation
     if (data === null || data === undefined) {
       return {
@@ -856,19 +856,19 @@ export class MetadataManager implements IMetadataService {
   }
 
   /**
-   * Watch for metadata changes (legacy API)
+   * Register a watch callback for metadata changes
    */
-  watch(type: string, callback: WatchCallback): void {
+  protected addWatchCallback(type: string, callback: WatchCallback): void {
     if (!this.watchCallbacks.has(type)) {
       this.watchCallbacks.set(type, new Set());
     }
     this.watchCallbacks.get(type)!.add(callback);
   }
 
   /**
-   * Unwatch metadata changes (legacy API)
+   * Remove a watch callback for metadata changes
    */
-  unwatch(type: string, callback: WatchCallback): void {
+  protected removeWatchCallback(type: string, callback: WatchCallback): void {
     const callbacks = this.watchCallbacks.get(type);
     if (callbacks) {
       callbacks.delete(callback);

packages/metadata/src/metadata.test.ts

@@ -191,7 +191,7 @@ describe('MetadataManager', () => {
   describe('watch / unwatch', () => {
     it('should register and invoke watch callbacks', () => {
       const callback = vi.fn();
-      manager.watch('object', callback);
+      (manager as any).addWatchCallback('object', callback);
 
       // Trigger via protected method — cast to access it
       (manager as any).notifyWatchers('object', {
@@ -207,8 +207,8 @@ describe('MetadataManager', () => {
 
     it('should unwatch callback', () => {
       const callback = vi.fn();
-      manager.watch('object', callback);
-      manager.unwatch('object', callback);
+      (manager as any).addWatchCallback('object', callback);
+      (manager as any).removeWatchCallback('object', callback);
 
       (manager as any).notifyWatchers('object', {
         type: 'changed',
@@ -222,7 +222,7 @@ describe('MetadataManager', () => {
     });
 
     it('should not throw when unwatching non-existent callback', () => {
-      expect(() => manager.unwatch('object', vi.fn())).not.toThrow();
+      expect(() => (manager as any).removeWatchCallback('object', vi.fn())).not.toThrow();
     });
   });