Fix code review feedback: improve type safety in handlers and registration

- Replace `as string ?? value` with `? String(x) : default` pattern
- Replace `Function` type with `(...args: unknown[]) => unknown`
- Remove `as any` casts in config lifecycle hooks

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>

Author: Copilot

examples/app-crm/objectstack.config.ts

@@ -36,8 +36,8 @@ import { registerCrmActionHandlers } from './src/actions/register-handlers';
  * Plugin lifecycle hook — called by AppPlugin when the engine is ready.
  * This is where action handlers are registered on the ObjectQL engine.
  */
-export const onEnable = async (ctx: { ql: { registerAction: Function } }) => {
-  registerCrmActionHandlers(ctx.ql as any);
+export const onEnable = async (ctx: { ql: { registerAction: (...args: unknown[]) => void } }) => {
+  registerCrmActionHandlers(ctx.ql);
 };
 
 export default defineStack({

examples/app-crm/src/actions/handlers/contact.handlers.ts

@@ -43,8 +43,8 @@ export async function sendEmail(ctx: ActionContext): Promise<{ activityId: strin
   const { record, engine, user, params } = ctx;
   const activity = await engine.insert('activity', {
     type: 'email',
-    subject: params?.subject as string ?? `Email to ${record.email}`,
-    body: params?.body as string ?? '',
+    subject: params?.subject ? String(params.subject) : `Email to ${record.email}`,
+    body: params?.body ? String(params.body) : '',
     contact_id: record._id as string,
     account_id: record.account_id as string,
     direction: 'outbound',

examples/app-crm/src/actions/handlers/global.handlers.ts

@@ -40,9 +40,9 @@ export async function logCall(ctx: ActionContext): Promise<{ activityId: string
   const { record, engine, user, params } = ctx;
   const activity = await engine.insert('activity', {
     type: 'call',
-    subject: params?.subject as string,
-    duration_minutes: params?.duration as number,
-    notes: params?.notes as string ?? '',
+    subject: params?.subject ? String(params.subject) : 'Untitled Call',
+    duration_minutes: params?.duration ? Number(params.duration) : 0,
+    notes: params?.notes ? String(params.notes) : '',
     related_to_id: record._id as string,
     direction: 'outbound',
     status: 'completed',

examples/app-crm/src/actions/register-handlers.ts

@@ -72,7 +72,7 @@ import {
  * ```
  */
 export function registerCrmActionHandlers(engine: {
-  registerAction(objectName: string, actionName: string, handler: Function): void;
+  registerAction(objectName: string, actionName: string, handler: (...args: unknown[]) => unknown): void;
 }): void {
   // ─── Lead Domain ───────────────────────────────────────────────────
   // ConvertLeadAction (type: flow) — also has server-side handler for

examples/app-todo/objectstack.config.ts

@@ -21,8 +21,8 @@ import { registerTaskActionHandlers } from './src/actions/register-handlers';
  * Plugin lifecycle hook — called by AppPlugin when the engine is ready.
  * This is where action handlers are registered on the ObjectQL engine.
  */
-export const onEnable = async (ctx: { ql: { registerAction: Function } }) => {
-  registerTaskActionHandlers(ctx.ql as any);
+export const onEnable = async (ctx: { ql: { registerAction: (...args: unknown[]) => void } }) => {
+  registerTaskActionHandlers(ctx.ql);
 };
 
 export default defineStack({

examples/app-todo/src/actions/register-handlers.ts

@@ -76,7 +76,7 @@ import {
  * ```
  */
 export function registerTaskActionHandlers(engine: {
-  registerAction(objectName: string, actionName: string, handler: Function): void;
+  registerAction(objectName: string, actionName: string, handler: (...args: unknown[]) => unknown): void;
 }): void {
   // ─── Script-type actions (server-side handlers) ────────────────────
   engine.registerAction('task', 'completeTask', completeTask);

examples/app-todo/src/actions/task.handlers.ts

@@ -89,8 +89,8 @@ export async function deleteCompletedTasks(ctx: ActionContext): Promise<void> {
 export async function deferTask(ctx: ActionContext): Promise<void> {
   const { record, engine, params } = ctx;
   await engine.update('task', record._id as string, {
-    due_date: params?.new_due_date as string,
-    defer_reason: params?.reason as string ?? null,
+    due_date: params?.new_due_date ? String(params.new_due_date) : null,
+    defer_reason: params?.reason ? String(params.reason) : null,
     status: 'waiting',
   });
 }
@@ -99,7 +99,7 @@ export async function deferTask(ctx: ActionContext): Promise<void> {
 export async function setReminder(ctx: ActionContext): Promise<void> {
   const { record, engine, params } = ctx;
   await engine.update('task', record._id as string, {
-    reminder_date: params?.reminder_date as string,
+    reminder_date: params?.reminder_date ? String(params.reminder_date) : null,
     has_reminder: true,
   });
 }