refactor(ui): reduce overlap — extract SortItemSchema, extend AppBrandingSchema

- Add shared SortItemSchema to enums.zod.ts (reuses SortDirectionEnum)
- ElementDataSourceSchema now uses shared SortItemSchema instead of inline sort
- RecordReviewConfigSchema now uses shared SortItemSchema instead of inline sort
- InterfaceBrandingSchema now extends AppBrandingSchema (adds coverImage only)
- Add SortItemSchema tests to enums.test.ts

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>

Author: Copilot

packages/spec/src/shared/enums.test.ts

@@ -2,6 +2,7 @@ import { describe, it, expect } from 'vitest';
 import {
   AggregationFunctionEnum,
   SortDirectionEnum,
+  SortItemSchema,
   MutationEventEnum,
   IsolationLevelEnum,
   CacheStrategyEnum,
@@ -46,6 +47,26 @@ describe('SortDirectionEnum', () => {
   });
 });
 
+describe('SortItemSchema', () => {
+  it('should accept valid sort item', () => {
+    const result = SortItemSchema.parse({ field: 'created_at', order: 'desc' });
+    expect(result.field).toBe('created_at');
+    expect(result.order).toBe('desc');
+  });
+
+  it('should reject without field', () => {
+    expect(() => SortItemSchema.parse({ order: 'asc' })).toThrow();
+  });
+
+  it('should reject without order', () => {
+    expect(() => SortItemSchema.parse({ field: 'name' })).toThrow();
+  });
+
+  it('should reject invalid order direction', () => {
+    expect(() => SortItemSchema.parse({ field: 'name', order: 'up' })).toThrow();
+  });
+});
+
 describe('MutationEventEnum', () => {
   it('should accept all mutation events', () => {
     const valid = ['insert', 'update', 'delete', 'upsert'];

packages/spec/src/shared/enums.zod.ts

@@ -18,6 +18,13 @@ export const SortDirectionEnum = z.enum(['asc', 'desc'])
   .describe('Sort order direction');
 export type SortDirection = z.infer<typeof SortDirectionEnum>;
 
+/** Reusable sort item — field + direction pair used across views, data sources, filters */
+export const SortItemSchema = z.object({
+  field: z.string().describe('Field name to sort by'),
+  order: SortDirectionEnum.describe('Sort direction'),
+}).describe('Sort field and direction pair');
+export type SortItem = z.infer<typeof SortItemSchema>;
+
 /** CRUD mutation events used across hook, validation, object CDC */
 export const MutationEventEnum = z.enum([
   'insert', 'update', 'delete', 'upsert',

packages/spec/src/ui/interface.zod.ts

@@ -2,8 +2,10 @@
 
 import { z } from 'zod';
 import { SnakeCaseIdentifierSchema } from '../shared/identifiers.zod';
+import { SortItemSchema } from '../shared/enums.zod';
 import { I18nLabelSchema, AriaPropsSchema } from './i18n.zod';
 import { PageRegionSchema, PageVariableSchema } from './page.zod';
+import { AppBrandingSchema } from './app.zod';
 
 /**
  * Interface Page Type Schema
@@ -32,10 +34,7 @@ export const InterfacePageTypeSchema = z.enum([
 export const RecordReviewConfigSchema = z.object({
   object: z.string().describe('Target object for review'),
   filter: z.any().optional().describe('Filter criteria for review queue'),
-  sort: z.array(z.object({
-    field: z.string().describe('Field name to sort by'),
-    order: z.enum(['asc', 'desc']).describe('Sort direction'),
-  })).optional().describe('Sort order for review queue'),
+  sort: z.array(SortItemSchema).optional().describe('Sort order for review queue'),
   displayFields: z.array(z.string()).optional()
     .describe('Fields to display on the review page'),
   actions: z.array(z.object({
@@ -92,10 +91,9 @@ export const InterfacePageSchema = z.object({
 /**
  * Interface Branding Schema
  * Visual branding overrides for an interface.
+ * Extends AppBrandingSchema with interface-specific properties (coverImage).
  */
-export const InterfaceBrandingSchema = z.object({
-  primaryColor: z.string().optional().describe('Primary theme color hex code'),
-  logo: z.string().optional().describe('Custom logo URL'),
+export const InterfaceBrandingSchema = AppBrandingSchema.extend({
   coverImage: z.string().optional().describe('Cover image URL for the interface landing'),
 });
 

packages/spec/src/ui/page.zod.ts

@@ -2,6 +2,7 @@
 
 import { z } from 'zod';
 import { SnakeCaseIdentifierSchema } from '../shared/identifiers.zod';
+import { SortItemSchema } from '../shared/enums.zod';
 import { I18nLabelSchema, AriaPropsSchema } from './i18n.zod';
 import { ResponsiveConfigSchema } from './responsive.zod';
 
@@ -42,10 +43,7 @@ export const ElementDataSourceSchema = z.object({
   object: z.string().describe('Object to query'),
   view: z.string().optional().describe('Named view to apply'),
   filter: z.any().optional().describe('Additional filter criteria'),
-  sort: z.array(z.object({
-    field: z.string().describe('Field name to sort by'),
-    order: z.enum(['asc', 'desc']).describe('Sort direction'),
-  })).optional().describe('Sort order'),
+  sort: z.array(SortItemSchema).optional().describe('Sort order'),
   limit: z.number().int().positive().optional().describe('Max records to display'),
 });