Commit ac1cc8c
authored
marketplace-install-local-state-machine-exempt.test.ts failed under a
full-repo `pnpm test` at 30s while passing every time the package ran
alone.
Both marketplace seed tests drive MarketplaceInstallLocalPlugin, whose
seeding path dynamically imports the real @objectstack/runtime (unmocked
on purpose, in both recordSeedSummary and mergeSeedDatasetsIntoKernel).
That cold import costs seconds by itself and multiples of that under a
fully parallel turbo run, and it is charged to whichever test triggers
it first.
The sibling marketplace-install-local-seed-lookup.test.ts was diagnosed
as exactly this — "an import stall, not a hang" — and raised to 120s.
This file was left at 30s and kept flaking the same way. The budget is
now aligned, with the rationale stated locally instead of only in the
sibling.
The flaky set is exactly the intersection of "does not mock
@objectstack/runtime" and "actually drives seeding":
conflict, bundle no mock, but never reach the import default
reseed, heal mock the module default
seed-lookup no mock, seeds 120s (already)
state-machine-exempt no mock, seeds 120s (here)
So the two tests #3785 recorded are the only two that can hit this, and
no other file needs the same treatment.
Evidence this is a budget shortfall and not a race: the assertion passes
(no missing seed rows), and under the same full-parallel load that
produced the 30076ms failure the test now completes in 15696ms. Note
that single pass alone does not prove the fix — 15.7s would have fit the
old budget too. The argument is the ratio: a cost whose typical value is
~15s under load, and which has been observed above 30s, cannot live
inside a 30s budget. 120s matches the sibling and leaves a genuine hang
detectable, just later.
Refs #3785
1 parent 90c2b15 commit ac1cc8c
2 files changed
Lines changed: 42 additions & 1 deletion
File tree
- .changeset
- packages/cloud-connection/src
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
Lines changed: 10 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
208 | 208 | | |
209 | 209 | | |
210 | 210 | | |
211 | | - | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
212 | 221 | | |
213 | 222 | | |
214 | 223 | | |
| |||
0 commit comments